Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add service product #1584 #1748

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Conversation

viktorwichern
Copy link
Contributor

Summary of the discussion

Discussions (e.g. in #1487 and #1239) have shown that we sometimes have to aggregate good and service which is difficult as good is a continuant and service is an occurent.

For this reason, we decided to add a continuant that expresses the value of a service.
We decided on a similar solution to how good is implemented and added a role and an equivalent class.

service product role
definition: A service product role is the role of an immaterial entity that is the result of a service process, and whose value is determined by the value and the costs of the service.

service product
definition: A service product is an immaterial entity that has the service product role.

Type of change (CHANGELOG.md)

Added

  • service product role
  • service product

Workflow checklist

Automation

Closes #1584

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@viktorwichern viktorwichern self-assigned this Nov 2, 2023
@github-actions github-actions bot added the oeo-shared changes the oeo-shared module label Nov 2, 2023
@viktorwichern viktorwichern marked this pull request as ready for review November 2, 2023 12:13
Copy link
Contributor

@stap-m stap-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add term tracker items @viktorwichern.

I am wondering, if oeo-shared is the right place. good lives there, but service is in oeo-social. Since we try to maintain the modular stucture, for which we did the restructuring after all, I am tending to suggest oeo-social here, too. @l-emele any opinion?

@viktorwichern
Copy link
Contributor Author

Please also add term tracker items @viktorwichern.

PR should be good to go, do you want to wait for an answer?

@l-emele
Copy link
Contributor

l-emele commented Nov 14, 2023

I am wondering, if oeo-shared is the right place. good lives there, but service is in oeo-social. Since we try to maintain the modular stucture, for which we did the restructuring after all, I am tending to suggest oeo-social here, too. @l-emele any opinion?

I agree that these should be in oeo-social.

@github-actions github-actions bot added the oeo-social changes the oeo-social module label Nov 18, 2023
@viktorwichern viktorwichern merged commit a3aa110 into dev Nov 20, 2023
4 checks passed
@viktorwichern viktorwichern deleted the feature-1584-add-service-product branch November 20, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-shared changes the oeo-shared module oeo-social changes the oeo-social module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add something like service product or non-material good
3 participants