Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add market share #1636

Closed
4 of 5 tasks
chrwm opened this issue Aug 24, 2023 · 6 comments · Fixed by #1779
Closed
4 of 5 tasks

Add market share #1636

chrwm opened this issue Aug 24, 2023 · 6 comments · Fixed by #1779
Assignees
Labels
[A] new term Including new term(s) in the ontology Depends on other issue or PR Cannot be solved / implemented until another issue or PR is solved. oeo-social changes the oeo-social module ready for implementation

Comments

@chrwm
Copy link
Member

chrwm commented Aug 24, 2023

Description of the issue

The concept market share seems not yet included.

Ideas of solution

Implement under quality.

Definition proposal: Market share is a quality of a market exchange which quantifies the proportion a good to the total amount of goods traded in that market exchange.

Workflow checklist

  • I discussed the issue with someone else than me before working on a solution
  • I already read the latest version of the workflow for this repository
  • The goal of this ontology is clear to me

I am aware that

  • every entry in the ontology should have a definition
  • classes should arise from concepts rather than from words
@chrwm chrwm added [A] new term Including new term(s) in the ontology To do Issues that haven't got discussed yet labels Aug 24, 2023
@chrwm chrwm self-assigned this Aug 24, 2023
@chrwm chrwm changed the title Add 'market share' Add market share Aug 24, 2023
@l-emele
Copy link
Contributor

l-emele commented Sep 5, 2023

I am fine with the proposal. I suggest that we also include the associated quantity value: A market share value is a fraction value that quantifies a market share.

@l-emele
Copy link
Contributor

l-emele commented Sep 26, 2023

No further comments, thus I I think market share and market share value are ready for implementation.

@l-emele l-emele added this to the oeo-release-2.0.0-thematical milestone Sep 26, 2023
@l-emele l-emele added oeo-social changes the oeo-social module ready for implementation labels Sep 26, 2023
@stap-m
Copy link
Contributor

stap-m commented Sep 26, 2023

Is it urgent to include this? If not, I'd recommend to wait for #1510

@stap-m stap-m added the Depends on other issue or PR Cannot be solved / implemented until another issue or PR is solved. label Sep 26, 2023
@github-actions github-actions bot removed the To do Issues that haven't got discussed yet label Sep 26, 2023
@l-emele
Copy link
Contributor

l-emele commented Sep 26, 2023

Not urgent in my view, I just went through a couple of issues and thought that this needs no further discussion. Seems I was wrong. ;)

@l-emele
Copy link
Contributor

l-emele commented Nov 21, 2023

Summary:

Add the following two classes:

  • market share: A market share is a quality of a market exchange which quantifies the proportion a good to the total amount of goods traded in that market exchange. (Small modification to the proposal above: I added an "A" at the start of the sentence which makes it more readable to me.)
  • market share value: A market share value is a fraction value that quantifies a market share.

@chrwm : Are you able to implement this yourself?

@chrwm
Copy link
Member Author

chrwm commented Nov 30, 2023

Yes, I'll implement it before the release.

chrwm added a commit that referenced this issue Dec 5, 2023
chrwm added a commit that referenced this issue Dec 5, 2023
@chrwm chrwm linked a pull request Dec 5, 2023 that will close this issue
5 tasks
chrwm added a commit that referenced this issue Dec 5, 2023
chrwm added a commit that referenced this issue Dec 5, 2023
chrwm added a commit that referenced this issue Dec 5, 2023
* market share
* market share value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[A] new term Including new term(s) in the ontology Depends on other issue or PR Cannot be solved / implemented until another issue or PR is solved. oeo-social changes the oeo-social module ready for implementation
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants