Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add market share and market share value #1779

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Conversation

chrwm
Copy link
Member

@chrwm chrwm commented Dec 5, 2023

Summary of the discussion

I added the terms to the shared-axioms-module.

Type of change (CHANGELOG.md)

Add

  • Added market share
  • Added market share value

Workflow checklist

Automation

Closes #1636

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@chrwm chrwm added the [A] new term Including new term(s) in the ontology label Dec 5, 2023
@chrwm chrwm added this to the oeo-release-2.1.0 milestone Dec 5, 2023
@chrwm chrwm requested a review from areleu December 5, 2023 09:13
@chrwm chrwm self-assigned this Dec 5, 2023
@chrwm chrwm linked an issue Dec 5, 2023 that may be closed by this pull request
5 tasks
@stap-m
Copy link
Contributor

stap-m commented Dec 5, 2023

I added the terms to the shared-axioms-module.

This module is only for axioms across modules! Is there a reason, why not oeo-social?

@chrwm chrwm marked this pull request as ready for review December 5, 2023 09:23
@chrwm
Copy link
Member Author

chrwm commented Dec 5, 2023

I added the terms to the shared-axioms-module.

This module is only for axioms across modules! Is there a reason, why not oeo-social?

No, it seemed for me that in the future it might intertwine with other concepts of other modules.
However, I can move it over to oeo-social for now.

@stap-m
Copy link
Contributor

stap-m commented Dec 5, 2023

I added the terms to the shared-axioms-module.

This module is only for axioms across modules! Is there a reason, why not oeo-social?

No, it seemed for me that in the future it might intertwine with other concepts of other modules. However, I can move it over to oeo-social for now.

In that case, the axioms will be implemented in oeo-shared-axioms, but the classes should stay at their "home module".

@github-actions github-actions bot added the oeo-social changes the oeo-social module label Dec 5, 2023
* market share
* market share value
@chrwm chrwm requested a review from stap-m December 5, 2023 09:48
@chrwm chrwm merged commit b4cbbbb into dev Dec 5, 2023
4 checks passed
@chrwm chrwm deleted the feature-1636-market-share branch December 5, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[A] new term Including new term(s) in the ontology oeo-shared-axioms oeo-social changes the oeo-social module
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Add market share
3 participants