move classes from oeo-shared(-axioms) to original modules #1652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
oeo-model
5 tasks
github-actions
bot
added
oeo-physical
…ture-1592-move-classes-to-physical
protégé changed some lines in the class of contact person here, but it seems like the annotations just have been slightly reordered
…://github.com/OpenEnergyPlatform/ontology into feature-1592-move-classes-to-original-modules
…://github.com/OpenEnergyPlatform/ontology into feature-1592-move-classes-to-original-modules
…://github.com/OpenEnergyPlatform/ontology into feature-1592-move-classes-to-original-modules
stap-m
commented
Sep 28, 2023
areleu
reviewed
Sep 28, 2023
Co-authored-by: e_arel <[email protected]>
…b.com:OpenEnergyPlatform/ontology into feature-1592-move-classes-to-original-modules
…://github.com/OpenEnergyPlatform/ontology into feature-1592-move-classes-to-original-modules
5 tasks
Co-authored-by: stap-m <[email protected]>
…b.com:OpenEnergyPlatform/ontology into feature-1592-move-classes-to-original-modules
l-emele
approved these changes
Sep 28, 2023
areleu
approved these changes
Sep 28, 2023
|
Thanks for the good teamwork @l-emele @areleu @nelekoehler @chrwm !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the discussion
From #1592
Type of change (CHANGELOG.md)
Added
Updated
Removed
Workflow checklist
Automation
Closes #
PR-Assignee
term tracker itemReviewer
Special to dos for this PR
After moving all classes we should clean the files by checking oeo-shared and oeo-shared-axioms for remnants of classes (unnecessary class declarations) and delete them.
Also there are classes (e.g.
person) which in the end stay untouched in oeo-shared. For those we do not need an updated term tracker item. Deleting for them the addition to the term tracker would reduce the overall change that we eventually bring to the dev branch.In the end, oeo-shared-axioms should contain no annotations (except term tracker items that might be fine in some cases). Especially there should be no definitions in oeo-shared-axioms.