Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean object properties from restructuring #1703

Closed
5 tasks
stap-m opened this issue Sep 28, 2023 · 2 comments
Closed
5 tasks

clean object properties from restructuring #1703

stap-m opened this issue Sep 28, 2023 · 2 comments
Labels
[B] restructure Restructuring existing parts of the ontology To do Issues that haven't got discussed yet

Comments

@stap-m
Copy link
Contributor

stap-m commented Sep 28, 2023

Description of the issue

related to #1592

After the restructuring and the huge PR #1652, the object properties in oeo-shared need to be reviewed.

Ideas of solution

Workflow checklist

  • I discussed the issue with someone else than me before working on a solution
  • I already read the latest version of the workflow for this repository
  • The goal of this ontology is clear to me

I am aware that

  • every entry in the ontology should have a definition
  • classes should arise from concepts rather than from words
@stap-m stap-m added [B] restructure Restructuring existing parts of the ontology To do Issues that haven't got discussed yet labels Sep 28, 2023
@stap-m
Copy link
Contributor Author

stap-m commented Sep 29, 2023

I think it is sensible to clean the object properties now, before doing anything else for the restructuring, to get a clean dev branch again.
EDIT: we will probably have to do that again after populating oeo-sector, but I think it might be worthwile to do it now anyway.

@stap-m
Copy link
Contributor Author

stap-m commented Sep 29, 2023

Step 1 would be to go through oeo-shared, look at the class remainders and check the object properties used, if they should be moved to another module for their domain and range.
Step 2 would be to check the other modules afterwards for remainders.

stap-m added a commit that referenced this issue Oct 2, 2023
stap-m added a commit that referenced this issue Oct 2, 2023
stap-m added a commit that referenced this issue Oct 2, 2023
stap-m added a commit that referenced this issue Oct 2, 2023
stap-m added a commit that referenced this issue Oct 2, 2023
stap-m added a commit that referenced this issue Oct 2, 2023
stap-m added a commit that referenced this issue Oct 2, 2023
stap-m added a commit that referenced this issue Oct 2, 2023
This was referenced Oct 4, 2023
stap-m added a commit that referenced this issue Oct 10, 2023
…bject-properties

move object properties from shared to original modules #1703
@stap-m stap-m closed this as completed Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[B] restructure Restructuring existing parts of the ontology To do Issues that haven't got discussed yet
Projects
Status: Done
Development

No branches or pull requests

1 participant