Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move remnant axioms #1710

Conversation

stap-m
Copy link
Contributor

@stap-m stap-m commented Oct 4, 2023

Summary of the discussion

Cleaning axioms in oeo-model and oeo-social
From #1703

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module labels Oct 4, 2023
@stap-m
Copy link
Contributor Author

stap-m commented Oct 4, 2023

  • We have life time and operational life time in oeo-physical. Its subclass economic life time lives currently in oeo-social. Options:
  1. move the life time class hierarchy to oeo-shared
  2. move economic life time also to oeo-physical

@github-actions github-actions bot added oeo-shared changes the oeo-shared module oeo-social changes the oeo-social module labels Oct 4, 2023
@l-emele
Copy link
Contributor

l-emele commented Oct 4, 2023

I suggest doing what is the smaller effort now which is in my view moving economic lifetime to oeo-physical. Looking at all the time span classes, I think we have to rework them sooner or later anyway. E.g. once we deal with #1510 .

@stap-m stap-m changed the title move remnant axioms to oeo shared axioms move remnant axioms Oct 4, 2023
@stap-m stap-m requested a review from l-emele October 4, 2023 19:50
@stap-m stap-m requested a review from areleu October 4, 2023 19:50
@stap-m stap-m self-assigned this Oct 4, 2023
Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

Side note: I struggeled a bit with commit d344185 and only saw later that you reverted it in b937502. It would have been helpful for reviewing if you had mentioned this mistake somewhere in the PR.

@stap-m
Copy link
Contributor Author

stap-m commented Oct 5, 2023

Looks fine.

Side note: I struggeled a bit with commit d344185 and only saw later that you reverted it in b937502. It would have been helpful for reviewing if you had mentioned this mistake somewhere in the PR.

I am sorry, thats right. Thanks for the review.

@stap-m stap-m merged commit 1d90e55 into feature-1703-clean-object-properties Oct 5, 2023
4 checks passed
@stap-m stap-m deleted the feature-1703-move-remnant-axioms-to-oeo-shared-axioms branch October 5, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module oeo-shared changes the oeo-shared module oeo-social changes the oeo-social module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants