Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce sector module #1724

Merged
merged 64 commits into from
Oct 23, 2023
Merged

Introduce sector module #1724

merged 64 commits into from
Oct 23, 2023

Conversation

stap-m
Copy link
Contributor

@stap-m stap-m commented Oct 17, 2023

Summary of the discussion

#1399
In this PR, the new sector module is generated and populated with all sectors, sector divisions and many sector individuals which originally lived in oeo-social.

Type of change (CHANGELOG.md)

Added

  • Added a new module oeo-sector.omn

Updated

  • move sector and sector division and subclasses to the new module

Workflow checklist

Automation

Closes #

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@stap-m stap-m marked this pull request as draft October 17, 2023 07:33
@github-actions github-actions bot added oeo-social changes the oeo-social module oeo-sector labels Oct 17, 2023
src/ontology/edits/oeo-social.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-social.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-social.omn Outdated Show resolved Hide resolved
@stap-m
Copy link
Contributor Author

stap-m commented Oct 17, 2023

I tried out several things and took a595d17 as template, but it the new module seems not to be recogized when I import it to oeo-shared-axioms. @areleu @l-emele @MGlauer any ideas what the problem is?

@l-emele
Copy link
Contributor

l-emele commented Oct 17, 2023

In file src/ontology/edits/catalog-v001.xml you have now both an Import Wizard Entry and an User Entered Import Resolution:

    <uri id="Imports Wizard Entry" name="http://openenergy-platform.org/ontology/oeo/dev/oeo-sector.omn" uri="oeo-sector.omn"/>
    <uri id="User Entered Import Resolution" name="http://openenergy-platform.org/ontology/oeo/dev/oeo-sector.omn" uri="oeo-sector.omn"/>

Maybe that is causing the problem?

Additionally, I noticed that when I open oeo.omn in your current branch, Protégé adds an additional entry into src/ontology/catalog-v001.xml

    <uri id="User Entered Import Resolution" name="http://openenergy-platform.org/ontology/oeo/dev/oeo-sector.omn" uri="edits/oeo-sector.omn"/>

@github-actions github-actions bot added the oeo-model changes the oeo-model module label Oct 20, 2023
@stap-m stap-m marked this pull request as ready for review October 20, 2023 19:53
@stap-m stap-m mentioned this pull request Oct 23, 2023
5 tasks
@l-emele l-emele mentioned this pull request Oct 23, 2023
5 tasks
Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not check commit by commit, but the overall changes in Protégé look fine.

I found one problem regarding some sector individuals. However this problem occurs not only in the feature branch of this PR but also in dev, so it was not introduced by this PR. Thus I created issue #1730

@stap-m stap-m merged commit 855b979 into dev Oct 23, 2023
4 checks passed
@stap-m stap-m deleted the feature-1399-introduce-sector-module branch October 25, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-model changes the oeo-model module oeo-sector oeo-shared changes the oeo-shared module oeo-shared-axioms oeo-social changes the oeo-social module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants