-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed depracation warnings in building routine #1935
base: dev
Are you sure you want to change the base?
Conversation
…recation Warnings
@@ -94,7 +94,7 @@ jobs: | |||
BRANCH_NAME="${PATHS[1]}_${PATHS[2]}" | |||
echo "BRANCH=$(echo ${BRANCH_NAME})" >> $GITHUB_ENV | |||
- name: Coverage Badge | |||
uses: schneegans/dynamic-badges-action@v1.0.0 | |||
uses: schneegans/dynamic-badges-action@v1.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change now makes the jobs fail.
The problem seems to be that the authentication fails. This isn't caused by using the newer version, the older version v1.0.0 didn't raise an error if writing to the gist failed. As visible in for example this 3-week-old job log the same step in the job logs an error:
Run schneegans/[email protected]
result:{"message":"Bad credentials","documentation_url":"https://docs.github.com/rest","status":"401"}
The job only doesn't fail, due to no actual error being raised.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Is this a problem that we can solve or is it due to an external repo that we use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It uses GitHub Gist to store information about the coverage and currently uses this gist of @areleu: https://gist.github.com/areleu/6d00affa9fbc89c79684d62091d96551
According to this action schneegans/dynamic-badges-action
, a Personal Access Token with the scope gist
has to be created and added as an organization secret like you did in #1936 with secrets.GITHUB_TOKEN
.
I assume that the token behind secrets.GIST_SECRET
ran out. So either a new token is created for the existing gist by @areleu or a new gist is created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite remember merging this to the main Repo, I had it in my personal branch to test it out and never really implemented it in here because I did not have the rights to add secrets, so I would say that the solution is to create a new gist/token that is specific to this repo. Not sure if gists can be created in a repository or they have to always be from an account. I could just send you a new key for that particular gist if we want to keep it simple
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think gists can be created for a repository or an organization.
I could just send you a new key for that particular gist if we want to keep it simple
Yeah, that seems like the easiest solution. I can't access the organizations secrets either, so you would have to send it to @stap-m. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created a new secret, I can update it with @stap-m later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Secret should be updated now
Summary of the discussion
The building routine / workflow produced a number of deprecation warnings due to some older Action versions being used.
This PR aims to fix this by updating the workflow to use newer versions.
There were no changes to the workflow config necessary, due to there being no breaking changes or only breaking changes not affecting our needs.
Type of change (CHANGELOG.md)
---
Workflow checklist
Automation
Closes #1859
PR-Assignee
term tracker item
Reviewer