Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed depracation warnings in building routine #1935

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Removed depracation warnings in building routine #1935

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/automated-testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-java@v2
- uses: actions/checkout@v4
- uses: actions/setup-java@v4
with:
distribution: 'adopt'
java-version: '11'
Expand All @@ -19,24 +19,24 @@ jobs:
- name: verify
run: |
java -jar build/robot.jar verify --input build/oeo/$(cat VERSION)/oeo-full.owl --queries tests/verify/*
- uses: actions/upload-artifact@master
- uses: actions/upload-artifact@v4
with:
name: build-artifacts
path: build/oeo
test:
runs-on: ubuntu-latest
needs: build
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- uses: actions/setup-python@v4
with:
python-version: '3.7'
architecture: x64
- uses: actions/setup-java@v2
- uses: actions/setup-java@v4
with:
distribution: 'adopt'
java-version: '11'
- uses: actions/download-artifact@master
- uses: actions/download-artifact@v4
with:
name: build-artifacts
path: build/oeo
Expand Down Expand Up @@ -68,7 +68,7 @@ jobs:
exit 1
- name: Upload Ontology
if: always()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: build-files
path: |
Expand All @@ -82,7 +82,7 @@ jobs:
# bash tests/competency_questions/run_questions.sh "java -jar build/hermit.jar" $(pwd)/build/oeo/$(cat VERSION)/oeo-full.owl false
- name: Upload Artifacts
if: always()
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: test-report
path: build/report.json
Expand All @@ -94,7 +94,7 @@ jobs:
BRANCH_NAME="${PATHS[1]}_${PATHS[2]}"
echo "BRANCH=$(echo ${BRANCH_NAME})" >> $GITHUB_ENV
- name: Coverage Badge
uses: schneegans/dynamic-badges-action@v1.0.0
uses: schneegans/dynamic-badges-action@v1.7.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change now makes the jobs fail.
The problem seems to be that the authentication fails. This isn't caused by using the newer version, the older version v1.0.0 didn't raise an error if writing to the gist failed. As visible in for example this 3-week-old job log the same step in the job logs an error:

Run schneegans/[email protected]
result:{"message":"Bad credentials","documentation_url":"https://docs.github.com/rest","status":"401"}

The job only doesn't fail, due to no actual error being raised.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Is this a problem that we can solve or is it due to an external repo that we use?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses GitHub Gist to store information about the coverage and currently uses this gist of @areleu: https://gist.github.com/areleu/6d00affa9fbc89c79684d62091d96551
According to this action schneegans/dynamic-badges-action, a Personal Access Token with the scope gist has to be created and added as an organization secret like you did in #1936 with secrets.GITHUB_TOKEN.
I assume that the token behind secrets.GIST_SECRET ran out. So either a new token is created for the existing gist by @areleu or a new gist is created.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite remember merging this to the main Repo, I had it in my personal branch to test it out and never really implemented it in here because I did not have the rights to add secrets, so I would say that the solution is to create a new gist/token that is specific to this repo. Not sure if gists can be created in a repository or they have to always be from an account. I could just send you a new key for that particular gist if we want to keep it simple

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think gists can be created for a repository or an organization.

I could just send you a new key for that particular gist if we want to keep it simple

Yeah, that seems like the easiest solution. I can't access the organizations secrets either, so you would have to send it to @stap-m. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a new secret, I can update it with @stap-m later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Secret should be updated now

with:
auth: ${{ secrets.GIST_SECRET }}
gistID: 6d00affa9fbc89c79684d62091d96551
Expand Down
Loading