Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create automated annotation for module identification #870

Closed
1 task
stap-m opened this issue Sep 13, 2021 · 18 comments
Closed
1 task

Create automated annotation for module identification #870

stap-m opened this issue Sep 13, 2021 · 18 comments
Assignees
Labels
enhancement New feature or request oeo dev meeting Discuss issue at oeo dev meeting ontology infrastructure

Comments

@stap-m
Copy link
Contributor

stap-m commented Sep 13, 2021

Description of the issue

From #862:
An annotation is needed that indicates the modules in which a class / object property is defined in. This holds especially for classes from oeo-shared.
To reduce the effort of maintenance, an automated assignement, e.g. when releasing, would be great.

Ideas of solution

Workflow checklist

  • I am aware of the workflow for this repository
@stap-m stap-m added enhancement New feature or request To do Issues that haven't got discussed yet labels Sep 13, 2021
@stap-m stap-m added this to the oeo-release-1.7.0 milestone Sep 14, 2021
@stap-m
Copy link
Contributor Author

stap-m commented Sep 23, 2021

The next release is planned for Oct 1st, which would be a great time for introducing such a tool... 😉
Is it complex? @adelmemariani @MGlauer @jannahastings

@jannahastings
Copy link
Contributor

I think this is probably too complex to do in a few days. I am not exactly sure how it would be tackled. There would certainly be edge cases that are tricky to assign one way or another.

@stap-m
Copy link
Contributor Author

stap-m commented Oct 7, 2021

from oeo-devmeeting 25:

  • automated annotation seems complex, might cause errors
  • developers need to check module manually before implementing!
  • MG proposed proposal hidden annotation option --> git commit hook?
    • check at each commit of annotation and module fit, else git error
      for added and moved classes and axioms
    • MG + AM will do a nerdy deepdive on this

@github-actions github-actions bot removed the To do Issues that haven't got discussed yet label Oct 7, 2021
@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Oct 21, 2021
@stale stale bot removed the stale already discussed issues that haven't got worked on for a while label Nov 23, 2021
@l-emele l-emele added the oeo dev meeting Discuss issue at oeo dev meeting label Nov 23, 2021
@stap-m stap-m mentioned this issue Nov 26, 2021
5 tasks
@stage1407
Copy link
Contributor

stage1407 commented Feb 24, 2022

Intermediate result:
Ability to create automatically an OWL-File that contains the belonging to a module (shared, physical, ...) for every IRI based on the schema: IRI oeo:OEO_belongs_to_module IRI of a module .
Uploads coming soon.

@stap-m
Copy link
Contributor Author

stap-m commented Mar 1, 2022

Not fully finished for release v1.9.
Since it is an important issue for our workflow, maybe release this in a minor version before v1.10 (May 1st).

@stage1407
Copy link
Contributor

stage1407 commented Mar 13, 2022

Current Bugs:

  • script doesn't adopt the prefixes of the previous ontologies automatically

@stage1407
Copy link
Contributor

stage1407 commented Apr 12, 2022

Now the branch should be updated.
Some things that are new:

  • You can use now the prefixes of the ontologies in the 'belongs-to-annotated' ontologies of the script
  • The decision to which module an entity belongs, will be done by a priority-rule of the following scheme:
    highest priority -> shared -> physical -> social -> model -> lowest priority

@jannahastings
Copy link
Contributor

Great! What is the name of the branch? (And just to double-check, did you push your commit?)

@stage1407
Copy link
Contributor

stage1407 commented May 8, 2022

I changed the milestone, because I won't have it implemented until tomorrow.

@chrwm
Copy link
Member

chrwm commented Sep 19, 2022

@stage1407 could you may give an update on the issue's status?
PR #1111 was closed without merging. Is the feature's development still ongoing?

@stage1407
Copy link
Contributor

My work on the issue has rested for the past few weeks.
Due to the fact that Janna left, I had lost sight of it.
I will see that the last problems are eliminated and it can be merged.

The biggest problems with it were last:

  • there are still wrong annotations
  • it is still inconvenient to call the script

@stage1407
Copy link
Contributor

Suspended until decision on distribution of modules has been made

@l-emele
Copy link
Contributor

l-emele commented Jan 26, 2023

Suspended until decision on distribution of modules has been made

This means no quick solution, therefore I move the milestone.

@l-emele
Copy link
Contributor

l-emele commented Sep 21, 2023

After the large OEO restructuring, do we still need this annotation? Maybe in oeo-shared-axioms?

@stap-m
Copy link
Contributor Author

stap-m commented Sep 21, 2023

We have 'belongs to module', which is outdated, though. Further, the new protege identifies the module automatically.
Therefore, the issue might be obsolete now. We should also consider removing the 'belongs to module' annotation before the next release.

@stap-m
Copy link
Contributor Author

stap-m commented Sep 29, 2023

This issue is not needed anymore, since 1) protege is now able to show the module itself, and 2) the restructuring in #1592. We can finally close it. 🎉

@stap-m stap-m closed this as completed Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request oeo dev meeting Discuss issue at oeo dev meeting ontology infrastructure
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants