-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 870 create automated annotation for module identification #1111
Feature 870 create automated annotation for module identification #1111
Conversation
- [ ] Creating the belonging annotation in each OMN - [ ] Checks, if run is necessary I'm unsure if the OMN files are still correct. I'm afraid I don't know this ontology well enough to judge the results for myself.
Just changed some stuff for managing the file system in the btma-directory.
Just deleted the big JAR :'D
Should handling know most prefixes. And checks if updating is necessary
":" -> "OEO:"
Build in the commented final-call additional to the test-call that shows the functionality in comparison to the unedited files. Deleted some outdated comments.
Edited the last loop for better overview on the procedure
Now the script follows the Priority-rule: shared->physical->social->model. The script extracts the prefixes of the ontology (without using ROBOT)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, nearly there. I have made detailed comments in various places in the code.
A general point is that the robot.jar has snuck into the commit again so this will need to be reverted once more.
A bigger issue is that the robot template command is creating new classes where the ID referred not to a class but to something else, e.g. an individual. Thus, we will need to keep track of the OWL type associated with the ID, which we can get from the original export and then pass back to the template command later. Let's discuss and implement this after the rest of the pipeline is working correctly as per the other code comments.
Updated requirements on annotator based on the review. Add a hint to the README.md for consistency
Ok, I've implemented your comments. But if anything is still open let me know. Edited: |
Should we also introduce numeric IDs for the representation of the oeo modules? |
No need to introduce numerical IDs for the oeo modules, we just use their IRIs directly. |
OK, good, so there is just one more thing to add after these changes are done. The script needs to keep track of the OWL type associated with the ID, for example, individual, class, or object property. Robot provides headers both for extracting this in the first step and for specifying it in the template. We need this because otherwise the robot template step at the end assumes that all the IDs should be classes, when they are not. |
Now the script extracts the type of each entity and adds it in the template.csv to hold the types of the entities of the ontology.
Two little changes. One for Tests and a comment.
Tried to fix it with the additional Prefix in the template
Ok the error arises from the fact that in the ontology e.g. 'http://www.geneontology.org/formats/oboInOwl#<http' is specified as IRI and such a thing can not be parsed, of course. I am surprised at this point that something is imported from the geneontology at all and not owl: that is used directly in the script to specify types. The main problem is that the http: of the following IRI ends up there. @jannahastings Otherwise I have to look the next days, why this is happening. |
@stage1407, I was just double checking the prefix command format in ROBOT:
so for our scenario that would be like this, I think:
|
implemented Loading Symbol + make script callable from the Terminal
Refactored, restructured, commented and documented
@stage1407 @jannahastings How far is this PR? |
Unfortunately, we did not yet make progress with solving the problem with the implementation of this issue :-(. |
This PR is not needed anymore, since 1) protege is now able to show the module itself, and 2) the restructuring in #1592. We can finally close it. 🎉 |
Opening a draft pull request so that I can add comments on the diff. Not to be merged yet.