Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add relation 'has economic value' #958

Closed
5 tasks
stap-m opened this issue Nov 25, 2021 · 7 comments · Fixed by #1034
Closed
5 tasks

Add relation 'has economic value' #958

stap-m opened this issue Nov 25, 2021 · 7 comments · Fixed by #1034
Assignees
Labels
[B] restructure Restructuring existing parts of the ontology

Comments

@stap-m
Copy link
Contributor

stap-m commented Nov 25, 2021

Description of the issue

From #866

We dont have a proper relation to connect e.g. emission certificate to CO2 price.
has quantity value-relations won't fit here.

Ideas of solution

We could define a relation like "has economic value".

Workflow checklist

  • I discussed the issue with someone else than me before working on a solution
  • I already read the latest version of the workflow for this repository
  • The goal of this ontology is clear to me

I am aware that

  • every entry in the ontology should have a definition
  • classes should arise from concepts rather than from words
@stap-m stap-m added [B] restructure Restructuring existing parts of the ontology To do Issues that haven't got discussed yet labels Nov 25, 2021
@stap-m
Copy link
Contributor Author

stap-m commented Nov 25, 2021

From #866 (comment) by @l-emele

I think we should add both economic value of as sub property of quantity value of and has economic value as sub property of has quantity value with economic value of being the inverse of has economic value.

Then we can e.g. add to social cost of carbon the axiom 'economic value' of some 'emission value'.

@stap-m
Copy link
Contributor Author

stap-m commented Nov 25, 2021

The def of quantity value of is A relation that relates a quantity value to its entity in reality., like "length value" and "hub height". But what are the entities in reality of economic values? So, I'd rather not make a relation "economic value of" subproperty of "quantity value of" but have it on the same level as subproperty of is about.
@jannahastings what do you think?

@stap-m
Copy link
Contributor Author

stap-m commented Nov 25, 2021

Btw, I spotted an inconsistency:

  • emission value 'has quantity value' some 'emission quantity value'
  • Def of emission quantity value is a quantity value that has a mass unit as unit. It is the quantity value of an emission value.
  • But the axiom is: emission quantity value 'quantity value of' some 'emission certificate'

@stap-m stap-m added this to the oeo-release-1.9.0 milestone Nov 25, 2021
@github-actions github-actions bot removed the To do Issues that haven't got discussed yet label Nov 25, 2021
@stap-m stap-m mentioned this issue Nov 26, 2021
5 tasks
@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Dec 10, 2021
@l-emele
Copy link
Contributor

l-emele commented Dec 16, 2021

I think, the last axiom should be the other way round ('emission certificate' 'has quantity value' some 'emission quantity value') and should be at the class emission certificate and not at the class emission quantity value, as every emission certificate is associated to an emission quantity value, but not every emission quantity value is associated to a emission certificate.

@stale stale bot removed the stale already discussed issues that haven't got worked on for a while label Dec 16, 2021
@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Dec 30, 2021
@stale stale bot removed the stale already discussed issues that haven't got worked on for a while label Feb 8, 2022
@stap-m
Copy link
Contributor Author

stap-m commented Feb 8, 2022

To sum up the issue:

add relations

  • economic value of as sub property of is about
  • has economic value as sub property of has quantity value

add axiom:

  • 'emission certificate' 'has quantity value' some 'emission quantity value'
  • 'CO2 price' 'economic value of' some 'emission certificate' and 'emission certificate' 'has economic value' some 'CO2 price'
  • social cost of carbon: 'economic value' of some 'emission value'
  • good / commodity has economic value some price (and vice versa)

@stap-m
Copy link
Contributor Author

stap-m commented Feb 14, 2022

Ready for implementation? @l-emele

@l-emele
Copy link
Contributor

l-emele commented Feb 14, 2022

I think so.

stap-m pushed a commit that referenced this issue Feb 18, 2022
stap-m pushed a commit that referenced this issue Feb 18, 2022
stap-m pushed a commit that referenced this issue Feb 18, 2022
l-emele added a commit that referenced this issue Feb 18, 2022
l-emele added a commit that referenced this issue Feb 18, 2022
stap-m pushed a commit that referenced this issue Feb 22, 2022
stap-m added a commit that referenced this issue Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[B] restructure Restructuring existing parts of the ontology
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants