Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add has-economic-value #958 #1034

Merged
merged 11 commits into from
Feb 24, 2022
Merged

add has-economic-value #958 #1034

merged 11 commits into from
Feb 24, 2022

Conversation

stap-m
Copy link
Contributor

@stap-m stap-m commented Feb 18, 2022

closes #958

@github-actions github-actions bot added the oeo-shared changes the oeo-shared module label Feb 18, 2022
@stap-m stap-m requested a review from l-emele February 18, 2022 11:35
Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it was easier to do it myself than to explain, I added domain, range and inverse for the new object properties.

Additionally:
In the current implementation, the hierarchies do not match. The the label implies a connection to CO2, but the definition doesn't. Seeing now all classes connected, it makes more sense to me if we:

  1. Relabel social cost of carbon to social cost of emission and update the definition to: Social cost of emission is the cost the society bears for an emission value.
  2. Include new subclass social cost of carbon emission: Social cost of carbon emission is the social cost of emission that the society bears for an greenhouse gas emission value.

And while thinking again, is this really a costs of process attributes? Or are these in fact costs of the processes themselves?

@stap-m
Copy link
Contributor Author

stap-m commented Feb 22, 2022

And while thinking again, is this really a costs of process attributes? Or are these in fact costs of the processes themselves?

I'll open a seperate issue for this: #1036.


SubClassOf:
OEO_00040009,
OEO_00020181,
OEO_00020179 some OEO_00140081,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 'economic value of' some 'greenhouse gas emission value'

Copy link
Contributor Author

@stap-m stap-m Feb 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This requires moving a bunch of classes to oeo-shared. Let's wait for #1036 here, to see what really needs to be moved.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@stap-m stap-m requested a review from l-emele February 23, 2022 11:20
@stap-m stap-m merged commit 58915ab into dev Feb 24, 2022
@stap-m stap-m deleted the feature-958-has-economic-value branch February 24, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-shared changes the oeo-shared module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add relation 'has economic value'
2 participants