Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

technology #1572 #1591

Merged
merged 8 commits into from
Jun 20, 2023
Merged

technology #1572 #1591

merged 8 commits into from
Jun 20, 2023

Conversation

stap-m
Copy link
Contributor

@stap-m stap-m commented Jun 20, 2023

Summary of the discussion

For the implementation of #1572, as a first step technology needs to be redefined.

Type of change (CHANGELOG.md)

Updated

  • technology is a plan specification that describes how to combine artificial objects or other material entities and processes in a specific way.

Workflow checklist

Automation

Closes #

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added the oeo-shared changes the oeo-shared module label Jun 20, 2023
@github-actions github-actions bot added the oeo-physical changes the oeo-physical module label Jun 20, 2023
@stap-m stap-m requested a review from l-emele June 20, 2023 09:08
@stap-m stap-m marked this pull request as ready for review June 20, 2023 09:08
@stap-m
Copy link
Contributor Author

stap-m commented Jun 20, 2023

The axiom added is a temporal solution and should be reviewed when #1572 is solved completely.

<http://purl.obolibrary.org/obo/IAO_0000136> some
(OEO_00000061
and (<http://purl.obolibrary.org/obo/RO_0000056> some
(OEO_00000419 or OEO_00140003)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the definition of technology (...to combine artificial objects or other material entities and processes in a specific way) I would prefer to have here the axiom 'is about' some ('artificial object' and ('participates in' some process). The narrowing down to specific processes comes then in the specific technology subclasses.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@l-emele
Copy link
Contributor

l-emele commented Jun 20, 2023

In the issue, I also proposed to have a general energy technology: An energy technology is a technology that describes how to combine energy transformation units, energy transformations, energy carriers and energy in a specific way.

Maybe we include this also in this PR, this would be then the common parent for power generation technology and heat generation technology were we can then work independently.

Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now.

@stap-m stap-m merged commit 8390c00 into dev Jun 20, 2023
@stap-m stap-m deleted the feature-1572-technology branch October 25, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-physical changes the oeo-physical module oeo-shared changes the oeo-shared module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants