Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specific energy transformations #1527 #1599

Closed
wants to merge 16 commits into from

Conversation

stap-m
Copy link
Contributor

@stap-m stap-m commented Jun 26, 2023

Summary of the discussion

Relations are moved to oeo-shared and classes are made equivalent classes.
TODO:

  • fix axiom such that the previous subclasses are still being inferred.
  • add "main input/output" to some/most/all classes, to be clarifyed in the issue

Type of change (CHANGELOG.md)

Updated

  • has main/auxillary energy input/output (oeo shared)
  • make equivalent classes:
    • heat generation proces
    • electricity generation process
    • heat transfer
    • electrical energy transfer
    • chemical energy transfer

Workflow checklist

Automation

Closes #1527

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@stap-m stap-m self-assigned this Jun 26, 2023
@github-actions github-actions bot added oeo-physical changes the oeo-physical module oeo-shared changes the oeo-shared module labels Jun 26, 2023
@stap-m
Copy link
Contributor Author

stap-m commented Jul 5, 2023

To proceed, some open questions have to be answered in the issue.

@stap-m
Copy link
Contributor Author

stap-m commented Jul 5, 2023

Ok, this PR is already huge. I will add further things later, once the open questens are discussed and open it for review now.

@stap-m stap-m marked this pull request as ready for review July 5, 2023 13:40
@stap-m stap-m requested review from l-emele and areleu July 5, 2023 13:40
@areleu
Copy link
Contributor

areleu commented Jul 5, 2023

Ok, this PR is already huge. I will add further things later, once the open questens are discussed and open it for review now.

This will take a while to review, I will try to make some time for it tomorrow.

Copy link
Contributor

@areleu areleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved without comment: OEO_00000300, OEO_00020257, OEO_00020258, OEO_00020259, OEO_00020260.

Is electrical energy transfer equivalent to electricity generation process ? Because this is being inferred by the reasoner.

Maybe we are missing a constraint there.

@stap-m
Copy link
Contributor Author

stap-m commented Jul 21, 2023

Is electrical energy transfer equivalent to electricity generation process ? Because this is being inferred by the reasoner.

See #1527 (comment) . I think we'll have to rediscuss the transfer hierarchy anyway.

@chrwm chrwm self-requested a review July 27, 2023 09:10
@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Aug 11, 2023
@l-emele
Copy link
Contributor

l-emele commented Oct 23, 2023

Reset to draft as this needs a new start

@l-emele l-emele marked this pull request as draft October 23, 2023 09:12
@stale stale bot removed the stale already discussed issues that haven't got worked on for a while label Oct 23, 2023
@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Mar 17, 2024
@stap-m
Copy link
Contributor Author

stap-m commented May 2, 2024

This is outdated. I close this PR now.

@stap-m stap-m closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-physical changes the oeo-physical module oeo-shared changes the oeo-shared module stale already discussed issues that haven't got worked on for a while
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Distinguish between energy transfer and specific energy transformations
3 participants