restructure the concept of regions #1745 #1749
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the discussion
While discussing Issue #1489 with the OVGU-Group, we agreed that the current structure of
spatial region
should be slightly changed.One reason for that is the fact that
study region
considered region
andinteracting region
are currently on the same hierarchical level as one-two-three and zero-dimensional region.We decided to add a meta concept that contains the different regions and to make the regions equivalent classes by adding corresponding roles.
Since
subregion
was only parent tostudy subregion
, which was not related in any way tostudy region
, I movedsubregion
under the new meta-class and implemented a correspondingstudy subregion role
, which is a child node ofstudy region role
.For now, I copied the examples of use from the regions, which means that they are part of both the role, and the equivalent class, which one could argue is somewhat superfluous.
New concepts:
region of relevance
:definition: A region of relevance is a spatial region that is mentioned in any study or analysis.
study region role
:definition: A study region role is a role of a region of relevance that is under investigation and consists entirely of one or more subregions.
study subregion role
:definition: A study subregion role is a study region role that refers to a subregion.
interacting region role
:definition: An interacting region role is a role of a region of relevance that interacts with a region of relevance that has the study region role. It is part of a region of relevance that has the considered region role, but not a study region role.
considered region role
:definition: A considered region role is the role of a region of relevance that is used in an analysis.
Updated definition:
subregion
:definition: A subregion is a region of relevance that is in every respect a component of a region of relevance, but never encompasses the entire extent of a region of relevance.
Type of change (CHANGELOG.md)
Added
Updated
Workflow checklist
Automation
Closes #1745
PR-Assignee
term tracker item
Reviewer