Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure the concept of regions #1745 #1749

Merged
merged 5 commits into from
Nov 20, 2023

Conversation

viktorwichern
Copy link
Contributor

@viktorwichern viktorwichern commented Nov 2, 2023

Summary of the discussion

While discussing Issue #1489 with the OVGU-Group, we agreed that the current structure of spatial region should be slightly changed.
One reason for that is the fact that study region considered region and interacting region are currently on the same hierarchical level as one-two-three and zero-dimensional region.

We decided to add a meta concept that contains the different regions and to make the regions equivalent classes by adding corresponding roles.

Since subregion was only parent to study subregion, which was not related in any way to study region, I moved subregion under the new meta-class and implemented a corresponding study subregion role, which is a child node of study region role.

For now, I copied the examples of use from the regions, which means that they are part of both the role, and the equivalent class, which one could argue is somewhat superfluous.

New concepts:

region of relevance:
definition: A region of relevance is a spatial region that is mentioned in any study or analysis.

study region role:
definition: A study region role is a role of a region of relevance that is under investigation and consists entirely of one or more subregions.

study subregion role:
definition: A study subregion role is a study region role that refers to a subregion.

interacting region role:
definition: An interacting region role is a role of a region of relevance that interacts with a region of relevance that has the study region role. It is part of a region of relevance that has the considered region role, but not a study region role.

considered region role:
definition: A considered region role is the role of a region of relevance that is used in an analysis.

Updated definition:

subregion:
definition: A subregion is a region of relevance that is in every respect a component of a region of relevance, but never encompasses the entire extent of a region of relevance.

Type of change (CHANGELOG.md)

Added

  • region of relevance
  • study region role
  • interacting region role
  • considered region role
  • study subregion role

Updated

  • subregion

Workflow checklist

Automation

Closes #1745

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added the oeo-model changes the oeo-model module label Nov 2, 2023
@viktorwichern viktorwichern self-assigned this Nov 2, 2023
@viktorwichern viktorwichern marked this pull request as ready for review November 2, 2023 16:29
Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add to all new region roles the axiom 'has bearer' some 'region of relevance'.

@viktorwichern viktorwichern merged commit 68817c8 into dev Nov 20, 2023
4 checks passed
@viktorwichern viktorwichern deleted the feature-1745-restructure-regions branch November 20, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-model changes the oeo-model module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

make regions roles instead of immaterial entities
3 participants