Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added area classification concepts from regional planning #1766 #1791

Merged
merged 13 commits into from
Jan 14, 2024

Conversation

viktorwichern
Copy link
Contributor

@viktorwichern viktorwichern commented Dec 18, 2023

To describe data sets, different areas of German regional planning had to be added. These are:
Vorranggebiete
Vorbehaltsgebiete
Eignungsgebiete
Vorranggebiete mit der Wirkung von Eignungsgebieten
After finding English labels and definitions we decided to implement these as roles and corresponding equivalent regions, where priority region with effect of suitable region has not one corresponding roles but inheres the roles of priority regions and suitable regions.
Since the concept of spatial planning policies was not yet in the ontology, we decided to add it.
While working on the issue, we realised that the definition of policy instrument was outdated and decided to change it.
For a more detailed overview, see issue #1766.

Add

  • priority region role
  • priority region
  • conditionally reserved region role
  • conditionally reserved region
  • suitable region role
  • suitable region
  • priority region with effect of suitable region
  • spatial planning policy

Change

  • policy instrument

Workflow checklist

Automation

Closes #1766

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@viktorwichern viktorwichern self-assigned this Dec 18, 2023
@github-actions github-actions bot added the oeo-model changes the oeo-model module label Dec 18, 2023
@github-actions github-actions bot added the oeo-social changes the oeo-social module label Dec 18, 2023
@viktorwichern viktorwichern marked this pull request as ready for review December 18, 2023 14:36
@stap-m
Copy link
Contributor

stap-m commented Jan 8, 2024

@viktorwichern could you please add the §7 Absatz 3 ROG as definition source and maybe link to https://www.gesetze-im-internet.de/rog_2008/__7.html

Copy link
Contributor

@stap-m stap-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelog file, too.

Copy link
Contributor

@stap-m stap-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly some minor changes for clean documentation.

src/ontology/edits/oeo-model.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-model.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-model.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-model.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-model.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-model.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-model.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-social.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-social.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-model.omn Show resolved Hide resolved
src/ontology/edits/oeo-model.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-model.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-model.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-model.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-model.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-model.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-model.omn Outdated Show resolved Hide resolved
Copy link
Contributor

@stap-m stap-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good to me now!

@viktorwichern viktorwichern merged commit 60fc7d9 into dev Jan 14, 2024
4 checks passed
@viktorwichern viktorwichern deleted the feature-1766-add-area-classification-concepts branch January 14, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-model changes the oeo-model module oeo-social changes the oeo-social module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

add terminology for area classification from regional planning
2 participants