Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class forecasting #1691 #1799

Merged
merged 4 commits into from
Feb 2, 2024
Merged

Add class forecasting #1691 #1799

merged 4 commits into from
Feb 2, 2024

Conversation

l-emele
Copy link
Contributor

@l-emele l-emele commented Jan 22, 2024

Summary of the discussion

Type of change (CHANGELOG.md)

Add

  • Class: forecasting model calculation: A forecasting model calculation is a model calculation that produces a forecast.
  • Alternative label: forecasting
  • Axiom: 'forecasting model calculation' 'has information output' some forecast

Workflow checklist

Automation

Closes #1691

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

Definition: _Forecasting is a model calculation that produces a forecast._
@github-actions github-actions bot added the oeo-model changes the oeo-model module label Jan 22, 2024
@l-emele l-emele requested a review from stap-m January 22, 2024 10:58
@l-emele l-emele marked this pull request as ready for review January 22, 2024 10:58
@stap-m
Copy link
Contributor

stap-m commented Jan 23, 2024

FYI: forecast time series are discussed here #1699
Meanwhile, I think the axiom forecasting 'has information output' some forecast is useful. We should also think about a class forecasting model.

@l-emele
Copy link
Contributor Author

l-emele commented Jan 24, 2024

The axiom forecasting 'has information output' some forecast is already there (line 1697).

Given the discussion in #1699 shall I add forecasting model calculation as alternative label to forecasting? (Or even use forecasting model calculation as main label and forecasting as alternative label?)

@l-emele
Copy link
Contributor Author

l-emele commented Jan 31, 2024

Given the discussion in #1699 shall I add forecasting model calculation as alternative label to forecasting? (Or even use forecasting model calculation as main label and forecasting as alternative label?)

@stap-m : You gave a thumbs up here. Which option for the main label do you prefer, forecasting model calculation or forecasting?

@stap-m
Copy link
Contributor

stap-m commented Feb 1, 2024

forecasting model calculation as main label.

@l-emele
Copy link
Contributor Author

l-emele commented Feb 1, 2024

forecasting model calculation as main label.

I switched the labels and adapted the definition accordingly. Please review!

@l-emele l-emele merged commit fcca909 into dev Feb 2, 2024
4 checks passed
@l-emele l-emele deleted the feature-1691-forecasting branch February 2, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-model changes the oeo-model module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Entity forecast SubClass of model calculation
2 participants