-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update UO #1690 #1820
Update UO #1690 #1820
Conversation
Error in build routine is fixed. But this one remains: @areleu is this error related to the list of terms that is created? Can you find out what causes the error? |
Please document in the CHANGELOG.md that the UO imports where updated. |
@@ -124,6 +138,7 @@ | |||
<!-- http://purl.obolibrary.org/obo/UO_0000000 --> | |||
|
|||
<owl:Class rdf:about="http://purl.obolibrary.org/obo/UO_0000000"> | |||
<obo:IAO_0000115>"A unit of measurement is a standardized quantity of a physical quality." [Wikipedia:Wikipedia]</obo:IAO_0000115> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A quick fix might be to manually convert in this single case back to rdfs:comment
. Then we are sure the oeo-viewer and other tools use our definition.
The uo-import script can then later (e.g. after the release) be adapted to make an exception for UO:0000000.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see now only one minor remaining problem which can be solved manually without using the script. I approve this PR assuming that this minor problem will be solved before merging.
Took a quick look and looks fine, at least I do not see any orphan classes. |
Summary of the discussion
New units and prefixes from Units Ontology are imported.
Closes #1690
Type of change (CHANGELOG.md)
Add
Update
Remove
Workflow checklist
Automation
Closes #
PR-Assignee
term tracker item
Reviewer