Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UO #1690 #1820

Merged
merged 11 commits into from
Mar 4, 2024
Merged

Update UO #1690 #1820

merged 11 commits into from
Mar 4, 2024

Conversation

stap-m
Copy link
Contributor

@stap-m stap-m commented Feb 29, 2024

Summary of the discussion

New units and prefixes from Units Ontology are imported.
Closes #1690

Type of change (CHANGELOG.md)

Add

  • Added a new class #

Update

  • uo-extracted.owl
  • oeo-import-edits

Remove

  • Removed a broken link #

Workflow checklist

Automation

Closes #

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@stap-m stap-m self-assigned this Feb 29, 2024
@github-actions github-actions bot added the oeo-shared changes the oeo-shared module label Feb 29, 2024
@stap-m
Copy link
Contributor Author

stap-m commented Mar 1, 2024

Error in build routine is fixed. But this one remains:

grafik

@areleu is this error related to the list of terms that is created? Can you find out what causes the error?

@l-emele
Copy link
Contributor

l-emele commented Mar 1, 2024

Please document in the CHANGELOG.md that the UO imports where updated.

@stap-m
Copy link
Contributor Author

stap-m commented Mar 1, 2024

Maybe "count unit" is the problem. It was imported and used before, but is not included in the import list anymore.
grafik

@stap-m stap-m requested a review from l-emele March 1, 2024 15:50
@@ -124,6 +138,7 @@
<!-- http://purl.obolibrary.org/obo/UO_0000000 -->

<owl:Class rdf:about="http://purl.obolibrary.org/obo/UO_0000000">
<obo:IAO_0000115>&quot;A unit of measurement is a standardized quantity of a physical quality.&quot; [Wikipedia:Wikipedia]</obo:IAO_0000115>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By converting UO's rdfs:comment to definition now unit has two definitions:
grafik

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick fix might be to manually convert in this single case back to rdfs:comment. Then we are sure the oeo-viewer and other tools use our definition.

The uo-import script can then later (e.g. after the release) be adapted to make an exception for UO:0000000.

Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now only one minor remaining problem which can be solved manually without using the script. I approve this PR assuming that this minor problem will be solved before merging.

@areleu
Copy link
Contributor

areleu commented Mar 4, 2024

Took a quick look and looks fine, at least I do not see any orphan classes.

@stap-m stap-m merged commit 0b99347 into dev Mar 4, 2024
3 checks passed
@stap-m stap-m deleted the feature-1690-update-uo branch March 4, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-shared changes the oeo-shared module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Units Ontology - full import?
3 participants