Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class "quantity" #1510 #1839

Merged
merged 7 commits into from
Apr 23, 2024
Merged

Add class "quantity" #1510 #1839

merged 7 commits into from
Apr 23, 2024

Conversation

nelekoehler
Copy link
Contributor

Summary of the discussion

As described in #1510 and #1752 we want to restructure quantity values. Therefore we need a class "quantity", which I added in this pull request. The definition has been derived from the International vocabulary of metrology — Basic and general concepts and associated terms (VIM).
Based on this implementation some existing entities have to be reclassified in following PRs.

Add

  • Added a new class "quantity": A quantity is a quality of a material entity where the quality has a quantifiably magnitude (i.e. quantity value) that can be expressed as a number and a unit.

Workflow checklist

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added the oeo-shared changes the oeo-shared module label Apr 19, 2024
@nelekoehler nelekoehler marked this pull request as ready for review April 19, 2024 08:22
@stap-m
Copy link
Contributor

stap-m commented Apr 19, 2024

Looks good. We might add the axiom quantity 'has quantity value' some 'quantity value'.

@l-emele
Copy link
Contributor

l-emele commented Apr 19, 2024

Looks good. We might add the axiom quantity 'has quantity value' some 'quantity value'.

Are there quantities which cannot have quantity values? I don't think so. Thus I suggest to make it an equivalent class: quantity EquivalentTo: quality and 'has quantity value' some 'quantity value'.

@stap-m stap-m self-requested a review April 22, 2024 12:16
@nelekoehler nelekoehler merged commit c9a38fa into dev Apr 23, 2024
4 checks passed
@nelekoehler nelekoehler deleted the feature-1510-add-quantity branch April 23, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-shared changes the oeo-shared module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants