-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Axiom to Final Energy Consumption Value #1832 #1841
Add Axiom to Final Energy Consumption Value #1832 #1841
Conversation
I just saw that energy consumption value is not related to |
Yes I agree, we should add the axiom to energy consumption value. I will do that and adjust the axiom of final energy consumption value then, so that it inherits it. Should I add both 'energy use' and 'consumption' or only 'energy use' because it is a subclass of 'consumption'? |
|
Co-authored-by: l-emele <[email protected]>
I've made the axiomatic change of primary energy consumption and changed the label. Since we were already adjusting the consumptions value, I changed the labels of the other to consumption values, added the old label as an alternative label and changed the axiom of gross inland energy consumption also to 'is about' some 'non-energy-use' instead of 'has part'. Do you agree with these changes? |
Could you please add an axiom to |
Why? Primary energy consumption is not the consumption of primary energy carriers. |
Co-authored-by: l-emele <[email protected]>
Co-authored-by: stap-m <[email protected]>
Co-authored-by: l-emele <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now some classes do not have any SubClassOf axioms. From a strictly ontological view that is fine, however that causes some problems on the OEP (e.g. the OEO viewer cannot display these properly. So could you please reinclude for the equivalent classes:
SubClassOf:
OEO_00240019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit unhappy about the axiomatisation of primary energy consumption value
and gross inland energy consumption value
. The axioms basically say, that any energy consumption value which excludes non-energy use is a PEC value and any energy consumption value which included non-energy use is a GIEC value. But this is not true.
Co-authored-by: l-emele <[email protected]>
Do you have an idea how to change that? If not, I will look into it next week and try to make a new suggestion. |
I will change the axioms about the non-energy use of final energy consumption value and gross inland consumption value from EquivalentTo to SubclassOf. |
@l-emele could you review this PR again? The Merging is still blocked, because you requested changes, which I have already implemented now. |
Summary of the discussion
As discussed in #1832 I added an axiom to final energy consumption and since it is a quantity value I adjusted the label and the definition, so that the distinction between quantity and quantity value becomes more clear.
Add
Update
Workflow checklist
Automation
Closes #1832
PR-Assignee
term tracker item
Reviewer