Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Axiom to Final Energy Consumption Value #1832 #1841

Merged

Conversation

nelekoehler
Copy link
Contributor

@nelekoehler nelekoehler commented Apr 22, 2024

Summary of the discussion

As discussed in #1832 I added an axiom to final energy consumption and since it is a quantity value I adjusted the label and the definition, so that the distinction between quantity and quantity value becomes more clear.

Add

  • Added an axiom: Equivalent to 'energy consuption value' and 'is about' some (consumption and 'has participant' some 'final energy carrier')

Update

  • changed label: final energy consumption
  • changed definition: Final energy consumption value is an energy consumption value expressing the magnitude of the energy delivered to and consumed by end users.

Workflow checklist

Automation

Closes #1832

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added the oeo-physical changes the oeo-physical module label Apr 22, 2024
@nelekoehler nelekoehler marked this pull request as ready for review April 22, 2024 10:02
@nelekoehler nelekoehler requested a review from stap-m April 22, 2024 10:14
@stap-m
Copy link
Contributor

stap-m commented Apr 23, 2024

I just saw that energy consumption value is not related to consumption or energy use. I'd proposed to add that axiom and have it inherited by final energy consumption value, instead of adding it to the equivalent axiom. Do you agree?

@nelekoehler
Copy link
Contributor Author

I just saw that energy consumption value is not related to consumption or energy use. I'd proposed to add that axiom and have it inherited by final energy consumption value, instead of adding it to the equivalent axiom. Do you agree?

Yes I agree, we should add the axiom to energy consumption value. I will do that and adjust the axiom of final energy consumption value then, so that it inherits it. Should I add both 'energy use' and 'consumption' or only 'energy use' because it is a subclass of 'consumption'?

@stap-m
Copy link
Contributor

stap-m commented Apr 23, 2024

energy use should be sufficient.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@stap-m stap-m self-requested a review April 24, 2024 06:45
@nelekoehler
Copy link
Contributor Author

I've made the axiomatic change of primary energy consumption and changed the label. Since we were already adjusting the consumptions value, I changed the labels of the other to consumption values, added the old label as an alternative label and changed the axiom of gross inland energy consumption also to 'is about' some 'non-energy-use' instead of 'has part'. Do you agree with these changes?

@stap-m
Copy link
Contributor

stap-m commented Apr 24, 2024

Could you please add an axiom to primary energy carrier to primary energy consumption value. To harmonize it with final energy consumption value, also make it a defined class?!

@l-emele
Copy link
Contributor

l-emele commented Apr 24, 2024

Could you please add an axiom to primary energy carrier to primary energy consumption value.

Why? Primary energy consumption is not the consumption of primary energy carriers.

Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now some classes do not have any SubClassOf axioms. From a strictly ontological view that is fine, however that causes some problems on the OEP (e.g. the OEO viewer cannot display these properly. So could you please reinclude for the equivalent classes:

    SubClassOf:
        OEO_00240019

@nelekoehler nelekoehler requested a review from l-emele April 25, 2024 12:02
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit unhappy about the axiomatisation of primary energy consumption value and gross inland energy consumption value. The axioms basically say, that any energy consumption value which excludes non-energy use is a PEC value and any energy consumption value which included non-energy use is a GIEC value. But this is not true.

Co-authored-by: l-emele <[email protected]>
@nelekoehler
Copy link
Contributor Author

I am a bit unhappy about the axiomatisation of primary energy consumption value and gross inland energy consumption value. The axioms basically say, that any energy consumption value which excludes non-energy use is a PEC value and any energy consumption value which included non-energy use is a GIEC value. But this is not true.

Do you have an idea how to change that? If not, I will look into it next week and try to make a new suggestion.

@nelekoehler
Copy link
Contributor Author

I will change the axioms about the non-energy use of final energy consumption value and gross inland consumption value from EquivalentTo to SubclassOf.

@nelekoehler nelekoehler requested a review from l-emele May 2, 2024 09:05
@nelekoehler
Copy link
Contributor Author

@l-emele could you review this PR again? The Merging is still blocked, because you requested changes, which I have already implemented now.

@nelekoehler nelekoehler merged commit 84e2795 into dev May 15, 2024
4 checks passed
@nelekoehler nelekoehler deleted the feature-1832-add-axiom-to-final-energy-consumption-value branch May 15, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-physical changes the oeo-physical module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add Axiom to Final Energy Consumption Value - oeox paper quick fix
3 participants