Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add model coupling, sector coupling and sector coupling technology #1521 #1842

Merged
merged 10 commits into from
Apr 24, 2024

Conversation

stap-m
Copy link
Contributor

@stap-m stap-m commented Apr 23, 2024

Summary of the discussion

Based on the discussion in #1521 I add model coupling, sector coupling, sector coupling technology

Type of change (CHANGELOG.md)

Add

  • model coupling
  • sector coupling
  • sector coupling technology

Workflow checklist

Automation

Closes #1521

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added the oeo-model changes the oeo-model module label Apr 23, 2024
@github-actions github-actions bot added the oeo-physical changes the oeo-physical module label Apr 23, 2024
@stap-m stap-m marked this pull request as ready for review April 23, 2024 09:51
@stap-m stap-m requested review from l-emele and areleu April 23, 2024 09:51
@stap-m stap-m requested a review from nelekoehler April 23, 2024 09:51
@stap-m stap-m self-assigned this Apr 23, 2024
@stap-m stap-m requested a review from l-emele April 24, 2024 06:26
Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, see comment. Apart from this it looks fine.

@stap-m stap-m merged commit 2701735 into dev Apr 24, 2024
4 checks passed
@stap-m stap-m deleted the feature-1521-sector-coupling branch April 24, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

sector coupling versus model coupling
2 participants