Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced term tracker item with term tracker annotation #1850 #1922

Merged

Conversation

madbkr
Copy link
Contributor

@madbkr madbkr commented Sep 16, 2024

Summary of the discussion

See Issue #1850

Type of change (CHANGELOG.md)

Update

Replaced term tracker item with term tracker annotation.

Workflow checklist

Automation

Closes #1850

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module oeo-sector oeo-shared changes the oeo-shared module oeo-social changes the oeo-social module labels Sep 16, 2024
@madbkr madbkr self-assigned this Sep 16, 2024
@madbkr madbkr marked this pull request as ready for review September 16, 2024 09:51
…term-tracker-item-with-term-tracker-annotation
@madbkr madbkr changed the title replaced term tracker item with term tracker annotation replaced term tracker item with term tracker annotation #1850 Sep 16, 2024
src/ontology/edits/oeo-model.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-model.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-shared.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-shared.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-shared.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-physical.omn Show resolved Hide resolved
src/ontology/edits/oeo-physical.omn Show resolved Hide resolved
src/ontology/edits/oeo-physical.omn Show resolved Hide resolved
src/ontology/edits/oeo-physical.omn Show resolved Hide resolved
@stap-m stap-m requested a review from l-emele September 16, 2024 12:21
@stap-m
Copy link
Contributor

stap-m commented Sep 16, 2024

@l-emele could you please also have a look at this PR, and in case commit my suggestions, if you agree?

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@l-emele l-emele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The replacements look fine.

I added some suggestions for additional changes.
Also the term trackers in the files oeo-import-edits.owl and oeo-physical-axioms.owl need to be replaced before we can close the issue.

General remark: More than 1600 change lines is way to much for one pull request. It is difficult to properly review so many changes at once. Next time split this into a couple of pull requests, e.g. one pull request per file as suggested in the issue.

@stap-m
Copy link
Contributor

stap-m commented Sep 17, 2024

I added some suggestions for additional changes.
Also the term trackers in the files oeo-import-edits.owl and oeo-physical-axioms.owl need to be replaced before we can close the issue.

@madbkr @LillyG901 could one of you please take care of this, ideally today?

@madbkr
Copy link
Contributor Author

madbkr commented Sep 17, 2024

@stap-m
I did the replacements for files 'oeo-import-edits.owl' and 'oeo-physical-axioms.owl'. Luckily there were only very few in these files.

Copy link
Contributor

@stap-m stap-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thanks! You can merge @madbkr

@madbkr
Copy link
Contributor Author

madbkr commented Sep 17, 2024

@stap-m
May I merge now once the checks are done?

@madbkr madbkr merged commit 72d4f19 into dev Sep 17, 2024
4 checks passed
@madbkr madbkr deleted the feature-1850-replaced-term-tracker-item-with-term-tracker-annotation branch September 17, 2024 09:16
@l-emele
Copy link
Contributor

l-emele commented Sep 17, 2024

The changes of commit 60fb1c9 replaced term tracker item with term tracker annotation only partly in the files oeo-import-edits.owl and oeo-physical-axioms.owl. I still find 28 uses in oeo-import-edits.owl and one use in oeo-physical-axioms.owl.

grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module oeo-sector oeo-shared changes the oeo-shared module oeo-social changes the oeo-social module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reconsidering the usage of term tracker item
3 participants