-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaced 'has bearer' with 'characteristic of' #1928
replaced 'has bearer' with 'characteristic of' #1928
Conversation
commit to be able to draft a pull request, for term tracker annotations
CHANGELOG.md Version [2.X.X] contains two "Changed" Sections. Is this on purpose? |
term tracker annotations were added during commit: 'replaced 'has bearer' with 'characteristic of' in all omn-files' |
I created PR #1930 to fix this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your changes look good, thanks!
I added a small addition to the term tracker annotation of good role.
Furthermore, there is one usage of has bearer
left at disposition
(oeo-shared) that should be replaced.
Co-authored-by: stap-m <[email protected]>
… of https://github.com/OpenEnergyPlatform/ontology into feature-1907-replace-has-bearer-with-characteristic-of
I'd suggest to also make |
I am fine with that. |
@LillyG901 for the obsoletion you can check how I did that in #1931. In the comment you can put "The relation was replaced by RO_0000052 (characteristic of). Please use this relation ans its subrelations in the future." |
… of https://github.com/OpenEnergyPlatform/ontology into feature-1907-replace-has-bearer-with-characteristic-of
Summary of the discussion
See issue #1907.
Type of change (CHANGELOG.md)
Update
replaced 'has bearer' with 'characteristic of' in
Workflow checklist
Automation
Closes #1907
PR-Assignee
term tracker item
Reviewer