Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced 'has bearer' with 'characteristic of' #1928

Merged
merged 13 commits into from
Sep 24, 2024

Conversation

LillyG901
Copy link
Contributor

@LillyG901 LillyG901 commented Sep 20, 2024

Summary of the discussion

See issue #1907.

Type of change (CHANGELOG.md)

Update

replaced 'has bearer' with 'characteristic of' in

  • oeo-model.omn
  • oeo-physical.omn
  • oeo-shared-axioms.omn
  • oeo-shared.omn
  • oeo-social.omn

Workflow checklist

Automation

Closes #1907

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

commit to be able to draft a pull request, for term tracker annotations
@LillyG901 LillyG901 self-assigned this Sep 20, 2024
@github-actions github-actions bot added the oeo-model changes the oeo-model module label Sep 20, 2024
@github-actions github-actions bot added oeo-physical changes the oeo-physical module oeo-shared changes the oeo-shared module oeo-shared-axioms oeo-social changes the oeo-social module labels Sep 20, 2024
@LillyG901
Copy link
Contributor Author

CHANGELOG.md Version [2.X.X] contains two "Changed" Sections. Is this on purpose?

@LillyG901
Copy link
Contributor Author

term tracker annotations were added during commit: 'replaced 'has bearer' with 'characteristic of' in all omn-files'

@l-emele l-emele mentioned this pull request Sep 20, 2024
5 tasks
@l-emele
Copy link
Contributor

l-emele commented Sep 20, 2024

CHANGELOG.md Version [2.X.X] contains two "Changed" Sections. Is this on purpose?

I created PR #1930 to fix this

@stap-m stap-m requested a review from l-emele September 20, 2024 09:26
@LillyG901 LillyG901 marked this pull request as ready for review September 20, 2024 09:26
Copy link
Contributor

@stap-m stap-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes look good, thanks!
I added a small addition to the term tracker annotation of good role.
Furthermore, there is one usage of has bearer left at disposition (oeo-shared) that should be replaced.

src/ontology/edits/oeo-shared.omn Outdated Show resolved Hide resolved
@stap-m
Copy link
Contributor

stap-m commented Sep 23, 2024

I'd suggest to also make has bearer obsolete. @l-emele what do you think?

@l-emele
Copy link
Contributor

l-emele commented Sep 23, 2024

I'd suggest to also make has bearer obsolete. @l-emele what do you think?

I am fine with that.

@stap-m
Copy link
Contributor

stap-m commented Sep 23, 2024

@LillyG901 for the obsoletion you can check how I did that in #1931. In the comment you can put "The relation was replaced by RO_0000052 (characteristic of). Please use this relation ans its subrelations in the future."

CHANGELOG.md Outdated Show resolved Hide resolved
@stap-m stap-m merged commit 90bf1f8 into dev Sep 24, 2024
4 checks passed
@stap-m stap-m deleted the feature-1907-replace-has-bearer-with-characteristic-of branch September 24, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oeo-model changes the oeo-model module oeo-physical changes the oeo-physical module oeo-shared changes the oeo-shared module oeo-shared-axioms oeo-social changes the oeo-social module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace has bearer with characteristic of
3 participants