Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New AeroDyn input file exposing new BEM options (polar BEM, skew momentum correction, sector averaging) #1909

Merged
merged 45 commits into from
May 8, 2024

Conversation

ebranlard
Copy link
Contributor

@ebranlard ebranlard commented Dec 1, 2023

Feature or improvement description

  • New AeroDyn input file
  • Sector averaging (for shear)
  • Skew momentum correction (for skew)
  • Polar BEM

Ressources

  • A converter to go from the old to new aerodyn input format is available:
from openfast_toolbox.converters.versions.aerodyn import ad30_to_ad40
ad = ad30_to_ad40(fileold, filenew)

Related issue, if one exists

  • Input file changes: # 1895
  • Link to other pull requests: dev-unstable-pointers

Impacted areas of the software
AeroDyn

Test results
No change expected as this introduces new options, and the input file is read as backward compatible.

  • Finish pull request
  • Make sure connections for the Shear weighting is done
  • Document changes - Live doc here
  • Add example file , here

Future pull request

  • Change all the r-test input files
  • Add aerodyn test case for new features

@ebranlard ebranlard added this to the v4.0.0 milestone Dec 1, 2023
@ebranlard ebranlard marked this pull request as draft December 1, 2023 02:35
@ebranlard ebranlard changed the base branch from dev-unstable-pointers to dev March 13, 2024 18:33
@ebranlard ebranlard changed the base branch from dev to dev-unstable-pointers March 13, 2024 18:36
@ebranlard ebranlard self-assigned this Mar 13, 2024
@ebranlard ebranlard force-pushed the f/AD-shear branch 2 times, most recently from 9ee85b2 to e83e8a4 Compare March 14, 2024 14:01
@andrew-platt
Copy link
Collaborator

andrew-platt commented May 6, 2024

@ebranlard, if/when you are done with the minor updates, I will plan on merging this in the next day or two.

@andrew-platt andrew-platt merged commit 753ac84 into OpenFAST:dev-unstable-pointers May 8, 2024
21 checks passed
andrew-platt added a commit that referenced this pull request May 8, 2024
@ebranlard
Copy link
Contributor Author

I've added a small converter for AD3.x to AD4.0 in the openfast_toolbox:

from openfast_toolbox.converters.versions.aerodyn import ad30_to_ad40
ad = ad30_to_ad40(fileold, filenew)

See example here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants