Platform independent compilation #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velo
reviewed
Dec 20, 2023
pom.xml
Outdated
| </condition> | ||
| <condition property="urlSlashesOsModifier" value="///"> | ||
| <and> | ||
| <os family="windows"></os> |
There was a problem hiding this comment.
ow windows.... gotta love that.
Funny enough, I'm on windows 11, but all work is done under WSL, so never noticed the problem
pom.xml
Outdated
| @@ -598,13 +598,42 @@ | |||
| <stagingProgressTimeoutMinutes>15</stagingProgressTimeoutMinutes> | |||
| </configuration> | |||
| </plugin> | |||
| <plugin> | |||
| <artifactId>maven-antrun-plugin</artifactId> | |||
There was a problem hiding this comment.
can we use maven profiles instead?
ant seems so 1994
| @@ -134,7 +134,8 @@ public void toString_() throws IOException { | |||
| BeanSerializer serializer = new BeanSerializer(); | |||
| serializer.setAddToString(true); | |||
| serializer.serialize(type, SimpleSerializerConfig.DEFAULT, new JavaWriter(writer)); | |||
| assertThat(String.valueOf(writer)).contains(" @Override\n" + " public String toString()"); | |||
There was a problem hiding this comment.
would a multine string fix this?
assertThat(String.valueOf(writer)).contains("""
@Override
public String toString()
""");
There was a problem hiding this comment.
Nope, text blocks always use \n
velo
approved these changes
Jan 5, 2024
|
I made a few changes to eliminate the need of a maven profile and asserting line endings... Lemme know what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.