dhis2 remove Class Log
#417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtuchi
requested review from
taylordowns2000 and
josephjclark
and removed request for
taylordowns2000
taylordowns2000
previously requested changes
Oct 23, 2023
There was a problem hiding this comment.
need a quick guide from @josephjclark here. i thought that printing the date was not necessary since that would be optionally (and later?) handled by the runtime. is that not the case?
|
@taylordowns2000 Yeah, datestamps will be added to all logs by the runtime. That's a good catch. I'd have just removed the class wrapper but you're right, no need to include the timestamps. They're actually a bit distracting the CLI. @mtuchi please go ahead and remove the timestamps |
josephjclark
approved these changes
Oct 24, 2023
josephjclark
approved these changes
Oct 24, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
remove Class Log and replaced
Log.successwithconsole.logLog.warnwithconsole.warnLog.errorwithconsole.errorIssues #416
Review Checklist
dev only changes don't need a changeset.