Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sftp disconnect on error #422

Merged
merged 3 commits into from
Oct 24, 2023
Merged

sftp disconnect on error #422

merged 3 commits into from
Oct 24, 2023

Conversation

mtuchi
Copy link
Collaborator

@mtuchi mtuchi commented Oct 24, 2023

Summary

handle error on commonExecute and improve operation time logs

Ref #421

Review Checklist

  • Does the PR do what it claims to do?
  • Are there any unit tests? Should there be?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.

@mtuchi mtuchi changed the title handle error on commonExecute sftp disconnect on error Oct 24, 2023
@mtuchi mtuchi marked this pull request as ready for review October 24, 2023 08:44
@mtuchi mtuchi requested a review from josephjclark October 24, 2023 08:44
@mtuchi
Copy link
Collaborator Author

mtuchi commented Oct 24, 2023

I can confirm that i have tested this locally, using a live sftp server
Merging this to main cc @josephjclark

@mtuchi mtuchi merged commit d05de5d into main Oct 24, 2023
@mtuchi mtuchi deleted the sftp-close-conn-on-error branch October 24, 2023 12:30
This was referenced Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant