salesforce add request() function
#465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtuchi
changed the title
salesforce Add request() functionsalesforce add request() function
josephjclark
requested changes
Jan 19, 2024
it's a JSON string request body
josephjclark
requested changes
Jan 30, 2024
packages/salesforce/src/Adaptor.js
Outdated
| * @param {String} options.method - HTTP method to use. Defaults to GET | ||
| * @param {Object} [options.headers] - Object of request headers | ||
| * @param {Object} [options.json] - A JSON string request body | ||
| * @param {Object} [options.body] - Request body |
There was a problem hiding this comment.
The body should probably have a string type here - although technically it's any body type supported by jsforce.request. So maybe no type is more appropriate
There was a problem hiding this comment.
@josephjclark from jsforce, the type is String - https://github.com/jsforce/jsforce/blob/master/lib/api/chatter.js#L60
josephjclark
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
request(path, options, callback)function in salesforceDetails
Using
state.connection.request()You can now send REST API request with given HTTP request info, with connected session information.Issues
Ref #464
Review Checklist
Before merging, the reviewer should check the following items:
dev only changes don't need a changeset.