Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add callback support for
parseXML
inhttp
and addoptions
andcallback
support forquery
insalesforce
Details
Callback is very useful especially when it's used in
each()
function. The callback support inparseXML
will make it easier to pluck out data fromstate.data.body
. See example belowFor
salesforce
i made some improvement for the query function to usequery(qs, options, callback)
. This will allow me to specify options like{ autoFetch: true }
which will make it easy to query more records using only thequery()
instead ofbulkQuery()
Eg:
With the given example above ⬆️ , If the results is more
2000
records. Then the function will auto-fetch the remaining records until we have all recordsCloses #394, #447
Review Checklist
Before merging, the reviewer should check the following items:
dev only changes don't need a changeset.