salesforce Fix autoFetch in query

[mtuchi]

Summary

This PR contain a fix autoFetch and code improvements for salesforce query() function. All result records are now merged into records array

Ref #644

Review Checklist

Before merging, the reviewer should check the following items:

• Does the PR do what it claims to do?
• Are there any unit tests? Should there be?
• Is there a changeset associated with this PR? Should there be? Note that
  dev only changes don't need a changeset.

[josephjclark]

@mtuchi this is targeted at main, not the salesforce epic. Is that right?

[josephjclark]

Ok, I think I get it.

In production, salesforce 4.8.1 will push an array of pages of results into state.references[]. So if there are two pages of data, you'll end up with something like this:

state.references: [
    [{
           done: true,
            totalSize: 6,
            records: [a, b, c],
    }, {
           done: true,
            totalSize: 6,
            records: [d, e, f],
    }]
]

The issue in #644 ins't necessarily a bug, just an unexpected design choice.

What this PR does is flattens those pages into a single item

state.references: [
    {
          done: true,
           totalSize: 6,
           records: [a, b, c, d, e, f],
    }
]

This still isn't the design I would choose, but we're fixing that in #691.

So this PR will fix the 4.x adaptor so that the old references design works a bit better, which is good for our legacy users.

But we'll need to port this fix over to the new 5.x branch.

[josephjclark]

Protip: when writing tests, make a little hack to make them fail, then discard the hack.

[josephjclark]

Oh don't call done() if there's an exception. If there's an exception we need this test to fail!

The same goes for the other tests in this describe block

[mtuchi]

Removed the .catch(done) for function in describe('query')

[josephjclark]

Hey, passing autofetch and autoFetch is pretty subtle and very easy to get wrong.

Can we maybe:
a) console.log whether we're going to autofetch
b) support both forms of autofetch

[josephjclark]

Getting closer, but still a few more changes. Thanks!

[mtuchi]

I have made the suggested improvements, please have a look

[josephjclark]

I'm gonna call this a patch release.

it's technically a breaking fix.

But we have a major version coming soon which I expect jobs to migrate to. This patch just ensures that the 4.x branch is stable and behaves as originally intended.