dhis2 better regex #822
Closed
dhis2 better regex #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephjclark
commented
Nov 14, 2024
| const result = shouldUseNewTracker('tracker/events'); | ||
| expect(result).to.be.true; | ||
| }); | ||
|
|
||
| it('should use the new tracker for trackedEntityInstance', () => { |
There was a problem hiding this comment.
This test fails right now, but I think it should pass.
I don't think we have support right now to map trackedEntityInstances to tracker/trackeEntities. But I think we should?
We support create('enrollments') and create ('trackedEntities'), so why not create ('trackedEntitiesInstances)?
josephjclark
commented
Nov 14, 2024
| it('should use the new tracker for trackedEntities', () => { | ||
| const result = shouldUseNewTracker('trackedEntities'); | ||
| expect(result).to.be.true; | ||
| }); | ||
|
|
||
| it('should use the new tracker for new tracker generally', () => { |
There was a problem hiding this comment.
Hmm. Question mark on this actually.
create should take a resourceType - not a path. So create('enrollments'), not create('tracker/enrollments'). Because create has opinions and does stuff for you.
If you want a custom create with the new tracker, do post('tracker/enrollments')
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows simpler regex and a few more tests