Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections: pass state into keygen #864

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Collections: pass state into keygen #864

merged 3 commits into from
Dec 11, 2024

Conversation

josephjclark
Copy link
Collaborator

Summary

This PR passes state into the keygen function (see release notes in the PR).

I've also added richer error handling if the keygen function doesn't return a string, which should catch attempts to use lazy state

Fixes #852

This is technically a breaking change but we're also pre-release and it's a very niche corner of the API (I don't think index actually has any value, I only pass it on for the sake of it).

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, added the adaptor on marketing website ?
  • Are there any unit tests?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.
  • Have you ticked a box under AI Usage?

@josephjclark josephjclark merged commit aa9315c into main Dec 11, 2024
2 checks passed
@josephjclark josephjclark deleted the collections-keygen branch December 11, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Collections: keygen can be hard in some cases
1 participant