Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for collections.set() #868

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Update docs for collections.set() #868

merged 2 commits into from
Dec 16, 2024

Conversation

mtuchi
Copy link
Collaborator

@mtuchi mtuchi commented Dec 16, 2024

Summary

Update documentation for collections.set() to include the name params and fix typo in examples

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Review Checklist

Before merging, the reviewer should check the following items:

  • Does the PR do what it claims to do?
  • If this is a new adaptor, added the adaptor on marketing website ?
  • Are there any unit tests?
  • Is there a changeset associated with this PR? Should there be? Note that
    dev only changes don't need a changeset.
  • Have you ticked a box under AI Usage?

and fix examples
@mtuchi mtuchi changed the title collection update jsdocs for set() Update docs for collections.set() Dec 16, 2024
@mtuchi mtuchi requested a review from josephjclark December 16, 2024 11:53
@mtuchi mtuchi marked this pull request as ready for review December 16, 2024 11:53
Copy link
Collaborator

@josephjclark josephjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@josephjclark josephjclark merged commit e650595 into main Dec 16, 2024
2 checks passed
@josephjclark josephjclark deleted the collection-docs branch December 16, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants