Fix RegExp in expandReferences

.changeset/nasty-pumpkins-teach.md

@@ -0,0 +1,5 @@
+---
+'@openfn/language-common': patch
+---
+
+Ensure that RegExp objects can be safely passed as references

packages/common/src/util/references.js

@@ -19,7 +19,11 @@ const isStream = value => {
 };
 
 function expandReference(state, value) {
-  if (Buffer.isBuffer(value)) {
+  if (
+    Buffer.isBuffer(value) ||
+    // Note: there is a weird identity thing in the VM where typeof RegExp will be false ¯\_(ツ)_/¯
+    value?.constructor?.name === 'RegExp'
+  ) {
     return value;
   }
 

packages/common/test/util/references.test.js

@@ -1,5 +1,8 @@
 import { expect } from 'chai';
-import { expandReferences, normalizeOauthConfig } from '../../src/util/index.js';
+import {
+  expandReferences,
+  normalizeOauthConfig,
+} from '../../src/util/index.js';
 
 describe('util expandReferences', () => {
   it('should not modify string references', () => {
@@ -11,6 +14,26 @@ describe('util expandReferences', () => {
     expect(resolvedName).to.equal('mulder');
   });
 
+  it('should ignore regex literals', () => {
+    const regex = /scully/;
+    const state = {};
+
+    const [resolvedRegex] = expandReferences(state, regex);
+
+    expect(resolvedRegex instanceof RegExp).to.be.true;
+    expect(resolvedRegex.test('scully')).to.be.true;
+  });
+
+  it('should ignore regex instances', () => {
+    const regex = new RegExp('scully');
+    const state = {};
+
+    const [resolvedRegex] = expandReferences(state, regex);
+
+    expect(resolvedRegex instanceof RegExp).to.be.true;
+    expect(resolvedRegex.test('scully')).to.be.true;
+  });
+
   it('should expand function references', () => {
     const state = { name: 'mulder' };
     const name = s => s.name;

packages/gmail/src/Utils.js

@@ -1,7 +1,8 @@
 import unzipper from 'unzipper';
 import { google } from 'googleapis';
 
-let gmail = undefined;
+let gmail;
+let isTesting;
 
 export async function fetchMessages(userId, query, lastPageToken) {
   let messagesResponse = null;