-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure results for SalesforceResultState
functions
#894
Conversation
bulk
and destroy
SalesforceResultState
functions
packages/salesforce/src/Utils.js
Outdated
@@ -134,3 +134,36 @@ export async function pollJobResult(conn, job, pollInterval, pollTimeout) { | |||
attempt++; | |||
} | |||
} | |||
|
|||
export function formatResults(input) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The integration tests are cool but I would value unit tests against this function way more!
I won't block the PR for tests on this though (especially as I've requested a change). If you have time for a few tests that's great. If you don't, don't worry.
What I'm really trying to say is: consider unit testing before integration testing. Also when you write a nice clean standalone util function like this, it's a great candidate for unit tests!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reminder I have added couple of unit test for formatResults
52834cf
to
d219d93
Compare
Summary
Restructured response format for
bulk
,create
,update
anddestroy
functions:Fixes #878
Details
Added standardized result structure:
For
bulk
function and fordestroy()
function when deleting multiple records. I have also added integration tests forbulk
,update
,destroy
andcreate
function, to run the test get credentials from LP:Salesforce Demo Org (API user)
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
dev only changes don't need a changeset.