Merge pull request #663 from OpenFn/error-msg-for-missing-wf

better error message for state/spec mismatch on deploy
OpenFn · Apr 17, 2024 · fbfc86f · fbfc86f
2 parents 94cec66 + 176dc39
commit fbfc86f
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 2 deletions.
diff --git a/packages/cli/CHANGELOG.md b/packages/cli/CHANGELOG.md
@@ -1,5 +1,12 @@
 # @openfn/cli
 
+## 1.2.2
+
+### Patch Changes
+
+- Updated dependencies [adfb661]
+  - @openfn/deploy@0.4.5
+
 ## 1.2.1
 
 ### Patch Changes

diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@openfn/cli",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "CLI devtools for the openfn toolchain.",
   "engines": {
     "node": ">=18",

diff --git a/packages/deploy/CHANGELOG.md b/packages/deploy/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @openfn/deploy
 
+## 0.4.5
+
+### Patch Changes
+
+- adfb661: Error message for when workflow found in 'state' but not 'spec' during deploy
+
 ## 0.4.4
 
 ### Patch Changes

diff --git a/packages/deploy/package.json b/packages/deploy/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@openfn/deploy",
-  "version": "0.4.4",
+  "version": "0.4.5",
   "description": "Deploy projects to Lightning instances",
   "type": "module",
   "exports": {

diff --git a/packages/deploy/src/stateTransform.ts b/packages/deploy/src/stateTransform.ts
@@ -216,6 +216,17 @@ export function mergeSpecIntoState(
           ];
         }
 
+        if (!specWorkflow && !isEmpty(stateWorkflow || {})) {
+          console.log(
+            'Workflow found in project state but not spec.',
+            `Spec: ${specWorkflow}`,
+            `State: ${stateWorkflow}`
+          );
+          throw new Error(
+            'Cannot continue: workflow from state not found in spec.'
+          );
+        }
+
         return [
           workflowKey,
           {