Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a little fix to
describe-package
which allows us to trackexport * as http from './http'
style export aliases.This has been a big problem and stops us using eg
http.get
in jobs.The problem is that our
wrapped-symbol.ts
, which wraps up a TS symbol into something more manageable, is failing to recognise exports of the typeexport * as
. Two small tweaks towrapped-symbol
fix it.One thing to note is that the generated package description now includes a
namespaces
array as well as afunctions
array. The nice thing about this is that the new exports won't break anything unexpected - we're adding new information to an export, we're not changing existing information,This fix will apply to the CLI and worker.
Related issue
Fixes #238 #363