Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lazy state stuff #661

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Fix lazy state stuff #661

merged 1 commit into from
Apr 11, 2024

Conversation

josephjclark
Copy link
Collaborator

This PR makes lazy state a bit more strict.

It explicitly ensures that a $ operator is being passed as an argument into a function.

If it has a statement or declaration as a parent before the call expression, an error will be thrown (not a great one tbh but there we go).

This is kind of a quick fix, I may relax the constraint if I think #660 is robust enough

@josephjclark josephjclark changed the base branch from main to release/next April 11, 2024 13:51
@josephjclark josephjclark merged commit 0a19ecb into release/next Apr 11, 2024
6 checks passed
@josephjclark josephjclark deleted the fix-lazy-state-stuff branch April 11, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant