-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: allow file paths for state and data in a workflow #715
Conversation
Thank you @SatyamMattoo - I'll take a look at this next week 🙏 |
This will also need testing and maybe implementing in the |
Okay sure, I will try doing that as well and push the changes for the review. For the testing part do you mean the integration tests or adding more tests here? |
Actually @SatyamMattoo forget about the deploy thing - I think that's actually a separate concern. I'll merge this and raise another issue for deploy if I need to (but on reflection we may not) |
Short Description
Allows the user to add file paths to the
state
anddata
in a workflow.Related issue
Fixes #639
Implementation Details
I have added a function that checks if the
state
is a file path. If it is, the function reads the file. Additionally, if thedata
(or any key insidestate
) is a file path, it will read that file and update the key with the file's content.For example, if we have
workflow.json
:state.json
:data.json
:It will compile the workflow as:
QA Notes
Added a test to verify that the file paths are identified, and the file content is successfully copied to the required key. Also tested it locally for different cases.
Checklist before requesting a review