Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

755 update jose #757

Closed
wants to merge 2 commits into from
Closed

755 update jose #757

wants to merge 2 commits into from

Conversation

rorymckinley
Copy link
Contributor

Short Description

Updates jose to a non-vulnerable version.

Related issue

Fixes #755

Implementation Details

Update of jose. I also included the changes that took place after I explicitly removed @types/prettier (separate commit) - I am not sure if these changes will make the issue around prettier better or worse. I am happy to revert that commit if it is the latter.

QA Notes

List any considerations/cases/advice for testing/QA here.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added unit tests
  • Changesets have been added (if there are production code changes)

Release branch checklist

I am not sure what the criteria are for a release branch - so I have not performed the steps below, but happy to do so.

If this IS a release branch:

  • Run pnpm changeset version from root to bump versions
  • Run pnpm install
  • Commit the new version numbers
  • Run pnpm changeset tag to generate tags
  • Push tags git push --tags

Tags may need updating if commits come in after the tags are first generated.

@rorymckinley
Copy link
Contributor Author

Closing as a result of pnpm user error - will resubmit with an changes applied via an appropriate version of pnpm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update jose to address vulnerability
1 participant