Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update node version (v18, v20, v22) #833

Merged
merged 31 commits into from
Dec 20, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
f857884
chore: move from ts-node to swc-loader
doc-han Nov 29, 2024
33f777d
ci: update CI to run tests for v18,v20,v22
doc-han Nov 29, 2024
1222c9c
fix: several tests & mocks
doc-han Nov 29, 2024
fc2e5e1
fix: resolve mock-fs
doc-han Dec 12, 2024
4cfd339
test: collection tests & flaky test
doc-han Dec 12, 2024
576b55e
tests: fix date output in integration test
josephjclark Dec 13, 2024
3c392a7
set node 22 and setup corepack on pnpm8
josephjclark Dec 16, 2024
f18bba5
update integration test matrix and use corepack
josephjclark Dec 16, 2024
1a125c2
fix yaml
josephjclark Dec 16, 2024
776707f
fix ndoe versions
josephjclark Dec 16, 2024
d602685
worker: bump image to node 22
josephjclark Dec 16, 2024
aa609c8
cli: type fix
josephjclark Dec 16, 2024
8ee83f1
compiler: update test fixture with trivial diff
josephjclark Dec 16, 2024
f0b3ed4
tests: tweak test matrix
josephjclark Dec 16, 2024
8904af2
runtime: await module import properly
josephjclark Dec 17, 2024
10a435e
cli: fix failing unit test
josephjclark Dec 17, 2024
8aa6bdd
cli: skipped tests that are broken by mock fs
josephjclark Dec 17, 2024
f701e60
cli: try to make docgen test a bit more stable in CI
josephjclark Dec 17, 2024
4913d36
cli: another attempt to stabilze docgen
josephjclark Dec 17, 2024
1158256
cli: give up and skip the flaky test
josephjclark Dec 17, 2024
8dc6edc
cli: skip another flaky test
josephjclark Dec 17, 2024
5ccc331
tests: remove logging
josephjclark Dec 17, 2024
5b2d9ad
compiler: remove .only
josephjclark Dec 17, 2024
5f15e1c
versions: [email protected] [email protected]
josephjclark Dec 17, 2024
3f5b10f
worker: fix version number output
josephjclark Dec 17, 2024
851b5cc
version: @openfn/[email protected]
josephjclark Dec 17, 2024
306e049
worker: typing
josephjclark Dec 17, 2024
4df5e77
worker: fix package.json resolution
josephjclark Dec 17, 2024
a053528
worker: typings
josephjclark Dec 17, 2024
fb670c0
engine: update package json importer
josephjclark Dec 17, 2024
dff4ed5
version: [email protected]
josephjclark Dec 17, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cli: try to make docgen test a bit more stable in CI
Or at least fail better
  • Loading branch information
josephjclark committed Dec 17, 2024
commit f701e60391db40d001f6f5ca2f07e0816beb1f68
2 changes: 1 addition & 1 deletion packages/cli/src/docgen/handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ const waitForDocs = async (
}
};

// This function deliberately blocks woth synchronous I/O
// This function deliberately blocks synchronous I/O
// while it looks to see whether docs need generating
const docgenHandler = (
options: Required<Pick<Opts, 'specifier' | 'repoDir'>>,
Expand Down
12 changes: 9 additions & 3 deletions packages/cli/test/docgen/handler.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ const mockGen: DocGenFn = async () =>
},
],
}),
100
300
);
});

Expand Down Expand Up @@ -155,13 +155,19 @@ test.serial(
const promise = docsHandler(options, logger, mockGen);
// the placeholder should already be created

const placeholder = JSON.parse(readFileSync(path, 'utf-8'));
const placeholder = await loadJSON(path);
t.truthy(placeholder);
t.true(placeholder.loading);
t.assert(typeof placeholder.timestamp === 'number');

// politely wait for the promise to run
await promise.then();
await promise
.then(() => {
t.pass();
})
.catch(() => {
t.fail();
});
}
);

Expand Down