PR feedback

OpenFn · Dec 10, 2024 · 1044631 · 1044631
1 parent be54aaa
commit 1044631
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/lib/lightning/work_orders.ex b/lib/lightning/work_orders.ex
@@ -200,10 +200,10 @@ defmodule Lightning.WorkOrders do
 
   defp try_put_snapshot(changeset, attrs) do
     if snapshot = attrs |> Map.get(:snapshot) do
-      changeset |> put_assoc(:snapshot, snapshot)
+      put_assoc(changeset, :snapshot, snapshot)
     else
       snapshot = Snapshot.get_current_for(attrs[:workflow])
-      changeset |> put_assoc(:snapshot, snapshot)
+      put_assoc(changeset, :snapshot, snapshot)
     end
   end
 

diff --git a/lib/lightning/workflows/snapshot.ex b/lib/lightning/workflows/snapshot.ex
@@ -264,10 +264,8 @@ defmodule Lightning.Workflows.Snapshot do
   @spec include_latest_snapshot(Multi.t(), binary() | :snapshot, Workflow.t()) ::
           Multi.t()
   def include_latest_snapshot(multi, name \\ :snapshot, workflow) do
-    get_snapshot = fn repo, _changes ->
+    Multi.run(multi, name, fn repo, _changes ->
       {:ok, get_current_query(workflow) |> repo.one()}
-    end
-
-    multi |> Multi.run(name, get_snapshot)
+    end)
   end
 end