Git-ignore files from mix assets.deploy

[jyeshe]

Description

This PR fixes the git ignore on Lightning for files generated by mix assets.deploy

Closes #2788

Validation steps

1. Run mix assets.deploy (before and after)

Additional notes

• This needs to be fixed also in the billing app but this one is for Lightning standalone (please see the state on the issue).
• .gitignore does not support {.ext1, ext2} notation

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

• Code generation (copilot but not intellisense)
• Learning or fact checking
• Strategy / design
• Optimisation / refactoring
• Translation / spellchecking / doc gen
• Other
• I have not used AI

You can read more details in our Responsible AI Policy

Pre-submission checklist

• I have performed a self-review of my code.
• I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
• I have updated the changelog.
• I have ticked a box in "AI usage" in this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.27%. Comparing base (ad06c03) to head (157a0ab).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2789   +/-   ##
=======================================
  Coverage   91.27%   91.27%           
=======================================
  Files         336      336           
  Lines       11946    11946           
=======================================
  Hits        10904    10904           
  Misses       1042     1042           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[taylordowns2000]

I suppose this is fine, but why have I never had any issues with these files before? Is mix assets.deploy actually used in any part of developing Lightning?

[jyeshe]

I suppose this is fine, but why have I never had any issues with these files before? Is mix assets.deploy actually used in any part of developing Lightning?

This is not an issue per se but there were recurring requests that these files should be gitignored on the billing app. When the assets are deployed on the umbrella app, it invokes all apps with the same command (except for mix test which was customised)

The mix assets.deploy is needed on releases and when it's done via Dockerfile we don't see them locally.

At last, the billing app can probably work now without digested deployment but this PR helps to avoid showing those files again (a following will be provided for the billing app).

[midigofrank]

Hey @jyeshe, great job!.

I'm worried about these two though:

/priv/static/images/*-*.png
/priv/static/images/*-*.svg 

We already have some images in there that were manually placed in there. Also, if we ever want to add a new image, where would we put it?

[jyeshe]

Hey @jyeshe, great job!.

I'm worried about these two though:

/priv/static/images/*-*.png
/priv/static/images/*-*.svg 

We already have some images in there that were manually placed in there. Also, if we ever want to add a new image, where would we put it?

Thanks Frank, that's correct. Repo-wise, the new ones are always ignored in favour of saved ones (the release goes along with the digest) and devs need to intentionally replace them with git add -f