try fixing mypy 2

OpenFogStack · Mar 26, 2024 · 77f3f0c · 77f3f0c
1 parent 1194d3e
commit 77f3f0c
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/pkg/ebpfem/ebpfem_test.go b/pkg/ebpfem/ebpfem_test.go
@@ -65,6 +65,7 @@ func TestBasic(t *testing.T) {
 
 	if _, err := cmd.CombinedOutput(); err != nil {
 		// ignore
+		log.Debugf("could not delete tap %s: %s", tap, err)
 	}
 
 	// iptables -D FORWARD -i [TAP_NAME] -o [HOSTINTERFACE] -j ACCEPT
@@ -73,6 +74,7 @@ func TestBasic(t *testing.T) {
 
 	if _, err := cmd.CombinedOutput(); err != nil {
 		// ignore
+		log.Debugf("could not delete iptables rule: %s", err)
 	}
 
 	// create a tap device

diff --git a/pkg/peer/peer.go b/pkg/peer/peer.go
@@ -241,6 +241,10 @@ func (p *PeeringService) InitPeering(remotes map[orchestrator.Host]HostInfo) err
 
 		portNum, err := strconv.ParseUint(port, 10, 16)
 
+		if err != nil {
+			return errors.WithStack(err)
+		}
+
 		r := &peer{
 			directAddr:  net.ParseIP(addr),
 			wgAddr:      remoteWgAddr,

diff --git a/pkg/virt/machine.go b/pkg/virt/machine.go
@@ -149,7 +149,7 @@ func (m *machine) initialize() error {
 		return errors.WithStack(err)
 	}
 
-	loglevel := "ERROR"
+	var loglevel string
 
 	// unfortunately Firecracker is incredibly verbose
 	switch log.GetLevel() {

diff --git a/pkg/virt/net.go b/pkg/virt/net.go
@@ -104,7 +104,7 @@ func removeNetworkDevice(tapName string, hostInterface string) error {
 }
 
 // createNetworkDevice creates a new network device for a microVM.
-func createNetworkDevice(gateway net.IPNet, tapName string, hostInterface string) error {
+func createNetworkDevice(gateway net.IPNet, tapName string, _ string) error {
 
 	// ip tuntap add [TAP_NAME] mode tap