-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have custom errors specific for protocols #385
Comments
I think a standard This is also somewhat related to #392. |
Some ideas for generic base protocol errors which could be subclassed or used by protocol developers the idea here is to make it clear at which stage the protocol has failed:
I think the examples, such as ring breaking or charge changes involving more than one formal charge unit, not being supported by the hybrid topology protocol would then be raised as a @hannahbaumann, @IAlibay @ijpulidos as protocol developers it would be great to get your input here on any other common failure modes that we could have a generic protocol error for and if these current errors seem reasonable. |
In OpenFreeEnergy/feflow#96 we encountered the case where it could be useful to have custom errors for protocols. For example, there are some limitations on the methodologies themselves that a protocol uses (such as hybrid topology generation not supporting ring breaking transformations), and also things that are just not allowed by the tooling, such as charge changing transformations that change more than one formal charge unit.
The idea being that we would like to have a shared/standard custom error that protocol authors could use. Is this something that we would like to have in gufe?
The text was updated successfully, but these errors were encountered: