Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to run on binder. #165

Closed
wants to merge 1 commit into from

Conversation

Carreau
Copy link

@Carreau Carreau commented Jul 14, 2018

Remove running as root, set a jovyan user, and update a few other
related configurations.

Here is some extra information when providing your own dockerfile

You can try on https://mybinder.org/v2/gh/carreau/geonotebook/master (my fork)

Remove running as root, set a jovyan user, and update a few other
related configurations.
@jbeezley
Copy link

Thanks for doing the leg work on this. We had attempted a binder deployment before. I believe we were blocked (in part) by #113. As a result, we have to hard code the URL of the embedded tile server. You can see the issue when trying to run the builtin raster example. It throws an error when trying to add the raster data object to the map.

@aashish24
Copy link
Member

@Carreau thanks for the PR. As we discussed earlier, I was hoping to use it for the workshop but as @jbeezley mentioned, the raster data example does not work because of the tile server url. Other basic examples are working fine.

@Carreau
Copy link
Author

Carreau commented Jul 16, 2018

Hum, you can likely use something like https://github.com/jupyterhub/nbserverproxy to fix this issue. I'll have to dig deeper into this though. It redirects traffic from a given URL to another service running on the same container.

This should allow you to set ktile_url to something like /ktile/ I doubt I can do that in 30 min though.

@aashish24
Copy link
Member

@Carreau sure. Is there any chance you could look into it further?

@Carreau Carreau closed this Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants