Refactor StoreTailer.readingDocument #1414
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgd
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
tgd
force-pushed
the
feature/refactor_StoreTailer_readDocument
branch
from
149451e to
d44dd6e
Compare
|
nicktindall
reviewed
Mar 25, 2024
| this.lastReadIndex = this.index(); | ||
| return context; | ||
| // An entry has been found, prepare the context and return it. | ||
| if (next && (context.wire() != null)) { |
There was a problem hiding this comment.
I notice we went from if (wire != null && context.present(next)) to if (next && context.wire() != null) I can see that context.present(...) just returns the value passed in but it also has the side-effect 🤮 of setting the present field in the context.
Is that change significant?
There was a problem hiding this comment.
Oh I see it happens in init now. Much nicer.
nicktindall
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring made during benchmarking session focusing on tailer throughput. The following differences were observed between this branch and develop during benchmarking:
This feature branch does the following:
#1415