Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add condition to check index in user_blocks #262

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Add condition to check index in user_blocks #262

merged 1 commit into from
Jan 17, 2025

Conversation

Rub21
Copy link

@Rub21 Rub21 commented Jan 8, 2025

Customize the migration script to evaluate if the index exists in the user_blocks table.

cc. @erictheise @danrademacher

@Rub21 Rub21 requested a review from erictheise January 8, 2025 19:53
erictheise
erictheise approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@erictheise erictheise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this because it's benign but I it is worrisome to me that this index already already exists if we haven't run the migration that creates it.

@Rub21 Rub21 merged commit eb75bd5 into staging Jan 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erictheise erictheise erictheise approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rub21 @erictheise