Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📕✨:add initial accessions: mount & umount commands (umount later) #22

Merged
merged 41 commits into from
Dec 27, 2023

Conversation

DerekNonGeneric
Copy link
Member

@DerekNonGeneric DerekNonGeneric commented Dec 27, 2023

Pull Request Purpose

Make a selection on the purpose(s) of your changes.

This PR contains the following:

  • 🐞🔧 bugfixing (🐜/🦟/🐛/🦗/🐝 et al.)
  • 🆕🎏 implementation of new feature(s)
  • ♻️ refactoring(s)
  • 📄 documentation modification(s)
  • 🔮 other

Testing

Have you included any tests in your submission?

  • yes (bugfixes and features will not be merged without
    tests
    )
  • no

Breaking Changes

Have you modified any aspect public API surface (i.e., caused breakage)?

  • yes (breaking changes will not be merged unless
    necessary
    )
  • no

Description

A concise recap summarily detailing what all are the changes being made.

Rich diff PR hyperlink:

Copy link

sweep-ai bot commented Dec 27, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@DerekNonGeneric DerekNonGeneric changed the title 📕✨:add initial accessions: mount 📕✨:add initial accessions: mount commands Dec 27, 2023
@DerekNonGeneric DerekNonGeneric added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 27, 2023
doc/glossary.md Outdated Show resolved Hide resolved
Signed-off-by: Derek Lewis <[email protected]>
doc/glossary.md Outdated Show resolved Hide resolved
doc/glossary.md Outdated Show resolved Hide resolved
Signed-off-by: Derek Lewis <[email protected]>
doc/glossary.md Outdated Show resolved Hide resolved
Signed-off-by: Derek Lewis <[email protected]>
doc/glossary.md Outdated Show resolved Hide resolved
Signed-off-by: Derek Lewis <[email protected]>
doc/glossary.md Outdated Show resolved Hide resolved
doc/glossary.md Outdated Show resolved Hide resolved
doc/glossary.md Outdated Show resolved Hide resolved
Signed-off-by: Derek Lewis <[email protected]>
doc/glossary.md Outdated Show resolved Hide resolved
doc/glossary.md Outdated Show resolved Hide resolved
doc/glossary.md Outdated Show resolved Hide resolved
doc/glossary.md Outdated Show resolved Hide resolved
doc/glossary.md Outdated Show resolved Hide resolved
doc/glossary.md Outdated Show resolved Hide resolved
Signed-off-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
doc/glossary.md Outdated Show resolved Hide resolved
Signed-off-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
Copy link
Member

@OpenINFbot OpenINFbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👽

@DerekNonGeneric DerekNonGeneric changed the title 📕✨:add initial accessions: mount & umount commands 📕✨:add initial accessions: mount & umount commands (umount later) Dec 27, 2023
doc/glossary.md Outdated Show resolved Hide resolved
doc/glossary.md Outdated Show resolved Hide resolved
doc/glossary.md Outdated Show resolved Hide resolved
doc/glossary.md Outdated Show resolved Hide resolved
doc/glossary.md Outdated Show resolved Hide resolved
doc/glossary.md Outdated Show resolved Hide resolved
doc/glossary.md Outdated Show resolved Hide resolved
Signed-off-by: Derek Lewis <[email protected]>
doc/glossary.md Outdated Show resolved Hide resolved
Signed-off-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
Signed-off-by: Derek Lewis <[email protected]>
doc/glossary.md Outdated Show resolved Hide resolved
doc/glossary.md Outdated Show resolved Hide resolved
@DerekNonGeneric DerekNonGeneric merged commit 1d1e163 into main Dec 27, 2023
4 checks passed
@DerekNonGeneric DerekNonGeneric deleted the DerekNonGeneric-adding-mount branch December 27, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants